Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify DEFINE_USHORT_ENUM types in cfapi.h #1252

Closed
goffrie opened this issue Sep 15, 2022 · 0 comments
Closed

Unify DEFINE_USHORT_ENUM types in cfapi.h #1252

goffrie opened this issue Sep 15, 2022 · 0 comments
Assignees
@mikebattista
Labels
missing enum An enum is missing for constant parameters

Comments

@goffrie
Copy link

goffrie commented Sep 15, 2022

Right now there is e.g. both CF_HYDRATION_POLICY_PRIMARY_USHORT and CF_HYDRATION_POLICY_PRIMARY, the latter being the type used for enum values (e.g. CF_HYDRATION_POLICY_FULL) and the former being used in data structures (e.g. CF_HYDRATION_POLICY). This means that the constants can't actually be used type-safely and need to be converted through a u16. Ideally the _USHORT types would just be removed.
@mikebattista mikebattista self-assigned this Feb 28, 2023
@mikebattista mikebattista added the missing enum An enum is missing for constant parameters label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikebattista mikebattista

Labels
missing enum An enum is missing for constant parameters
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goffrie @mikebattista