Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't conflate BCrypt and NCrypt #1012

Closed
kennykerr opened this issue Jul 26, 2022 · 2 comments
Closed

Don't conflate BCrypt and NCrypt #1012

kennykerr opened this issue Jul 26, 2022 · 2 comments
Assignees
@mikebattista
Labels
broken api An API is inaccurate and could lead to runtime failure bug Something isn't working missing enum An enum is missing for constant parameters rust Critical for Rust adoption

Comments

@kennykerr
Copy link
Contributor

These are similar but distinct APIs. Unfortunately in some places the types are a little mixed up. For example, BCryptEncrypt expects a NCRYPT_FLAGS parameter. This enum also mixes BCrypt and NCrypt flags, which isn't right.
@kennykerr
Copy link
Contributor Author

There are also various flags like BCRYPT_BLOCK_PADDING that aren't part of the enum.

@kennykerr kennykerr mentioned this issue Jul 27, 2022
Merged
@riverar
Copy link
Collaborator

riverar commented Jul 28, 2022 •
edited
Loading

Not sure distinct is the word I'd use. ncrypt.h brings in bcrypt.h, shares a bunch of types, and creates a bunch of type aliases between the two. Definitely needs some untangling in metadata!

@riverar riverar added bug Something isn't working missing enum An enum is missing for constant parameters broken api An API is inaccurate and could lead to runtime failure labels Jul 28, 2022
@mikebattista mikebattista self-assigned this Aug 1, 2022
@kennykerr kennykerr added the rust Critical for Rust adoption label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikebattista mikebattista

Labels
broken api An API is inaccurate and could lead to runtime failure bug Something isn't working missing enum An enum is missing for constant parameters rust Critical for Rust adoption
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@riverar @kennykerr @mikebattista