From c894647e175acae11ed4afe9d76c4bb5b34d7587 Mon Sep 17 00:00:00 2001
From: Russell Kennington <arussellk@gmail.com>
Date: Sat, 11 May 2019 17:01:29 -0600
Subject: [PATCH] Fix #72587 suggestWidget no scroll on first open

If the first time the suggestWidget was opened (ctrl+space) its
content vertically overflowed, it would not scroll. This commit fixes
suggestWidget so that it scrolls tall content even on first use.
The maxHeight must be set before scanDomNode checks clientHeight.
---
 src/vs/editor/contrib/suggest/suggestWidget.ts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/vs/editor/contrib/suggest/suggestWidget.ts b/src/vs/editor/contrib/suggest/suggestWidget.ts
index 054feaf901f6a..03d1327caf58e 100644
--- a/src/vs/editor/contrib/suggest/suggestWidget.ts
+++ b/src/vs/editor/contrib/suggest/suggestWidget.ts
@@ -965,8 +965,10 @@ export class SuggestWidget implements IContentWidget, IListVirtualDelegate<Compl
 		this.expandSideOrBelow();
 
 		show(this.details.element);
-		this.details.render(this.list.getFocusedElements()[0]);
+
+		// Set maxHeight before .render() as Fix for #72587
 		this.details.element.style.maxHeight = this.maxWidgetHeight + 'px';
+		this.details.render(this.list.getFocusedElements()[0]);
 
 		// Reset margin-top that was set as Fix for #26416
 		this.listElement.style.marginTop = '0px';