From def84eeebd0cdc14e29e89ff53826def691b27c4 Mon Sep 17 00:00:00 2001 From: ChaseKnowlden Date: Wed, 1 Mar 2023 19:24:35 -0500 Subject: [PATCH 1/4] Drop support for windows versions prior to windows 10 --- build/win32/code.iss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/win32/code.iss b/build/win32/code.iss index 7754562225b32..44c9f2f1f0b29 100644 --- a/build/win32/code.iss +++ b/build/win32/code.iss @@ -26,7 +26,7 @@ SetupIconFile={#RepoDir}\resources\win32\code.ico UninstallDisplayIcon={app}\{#ExeBasename}.exe ChangesEnvironment=true ChangesAssociations=true -MinVersion=6.2 +MinVersion=10.0 SourceDir={#SourceDir} AppVersion={#Version} VersionInfoVersion={#RawVersion} From cc2227233dd30fbeb33027460a5f517542c814c7 Mon Sep 17 00:00:00 2001 From: ChaseKnowlden Date: Fri, 3 Mar 2023 16:31:56 -0500 Subject: [PATCH 2/4] Prepare for windows 8 eol --- src/vs/workbench/electron-sandbox/window.ts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/vs/workbench/electron-sandbox/window.ts b/src/vs/workbench/electron-sandbox/window.ts index fd3bc081ea6ea..918545da0ebf9 100644 --- a/src/vs/workbench/electron-sandbox/window.ts +++ b/src/vs/workbench/electron-sandbox/window.ts @@ -787,6 +787,22 @@ export class NativeWindow extends Disposable { } ); } + + if (parseInt(version[0]) === 6 && parseInt(version[1]) === 2 || parseInt(version[0]) === 6 && parseInt(version[1]) === 3) { + const message = localize('windows 8 eol', "{0} o Windows 8/8.1 will no longer receive any further updates.", this.productService.nameLong); + + this.notificationService.prompt( + Severity.Warning, + message, + [{ + label: localize('learnMore', "Learn More"), + run: () => this.openerService.open(URI.parse('https://aka.ms/vscode-faq-win8')) + }], + { + neverShowAgain: { id: 'windows8eol', isSecondary: true, scope: NeverShowAgainScope.APPLICATION } + } + ); + } } // MacOS 10.11 and 10.12 warning From d205e72ba8c48ae4ac9f6332a2c44918333a7ca7 Mon Sep 17 00:00:00 2001 From: ChaseKnowlden Date: Fri, 3 Mar 2023 16:33:11 -0500 Subject: [PATCH 3/4] fix typo --- src/vs/workbench/electron-sandbox/window.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/electron-sandbox/window.ts b/src/vs/workbench/electron-sandbox/window.ts index 918545da0ebf9..f5369ca72f53d 100644 --- a/src/vs/workbench/electron-sandbox/window.ts +++ b/src/vs/workbench/electron-sandbox/window.ts @@ -789,7 +789,7 @@ export class NativeWindow extends Disposable { } if (parseInt(version[0]) === 6 && parseInt(version[1]) === 2 || parseInt(version[0]) === 6 && parseInt(version[1]) === 3) { - const message = localize('windows 8 eol', "{0} o Windows 8/8.1 will no longer receive any further updates.", this.productService.nameLong); + const message = localize('windows 8 eol', "{0} on Windows 8/8.1 will no longer receive any further updates.", this.productService.nameLong); this.notificationService.prompt( Severity.Warning, From c4ee8c5359884dcd243dbd789b8cfd2fa2a391e2 Mon Sep 17 00:00:00 2001 From: ChaseKnowlden Date: Thu, 23 Mar 2023 19:47:10 +0000 Subject: [PATCH 4/4] Revert "Prepare for windows 8 eol" This reverts commit f65a7107280da4328014d4964ba432f3d7462de0. --- src/vs/workbench/electron-sandbox/window.ts | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/src/vs/workbench/electron-sandbox/window.ts b/src/vs/workbench/electron-sandbox/window.ts index f5369ca72f53d..fd3bc081ea6ea 100644 --- a/src/vs/workbench/electron-sandbox/window.ts +++ b/src/vs/workbench/electron-sandbox/window.ts @@ -787,22 +787,6 @@ export class NativeWindow extends Disposable { } ); } - - if (parseInt(version[0]) === 6 && parseInt(version[1]) === 2 || parseInt(version[0]) === 6 && parseInt(version[1]) === 3) { - const message = localize('windows 8 eol', "{0} on Windows 8/8.1 will no longer receive any further updates.", this.productService.nameLong); - - this.notificationService.prompt( - Severity.Warning, - message, - [{ - label: localize('learnMore', "Learn More"), - run: () => this.openerService.open(URI.parse('https://aka.ms/vscode-faq-win8')) - }], - { - neverShowAgain: { id: 'windows8eol', isSecondary: true, scope: NeverShowAgainScope.APPLICATION } - } - ); - } } // MacOS 10.11 and 10.12 warning