From cf3711a3aba7348c41452acd4a7bff61ab84281a Mon Sep 17 00:00:00 2001 From: David Dossett Date: Thu, 20 Oct 2022 11:36:13 -0700 Subject: [PATCH] Updates menu item margin and radius and adds border to default themes --- extensions/theme-defaults/themes/dark_vs.json | 4 +++- extensions/theme-defaults/themes/light_vs.json | 1 + src/vs/base/browser/ui/menu/menu.ts | 4 +++- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/extensions/theme-defaults/themes/dark_vs.json b/extensions/theme-defaults/themes/dark_vs.json index 7b3c8d5e6fd70..ab05161619f1d 100644 --- a/extensions/theme-defaults/themes/dark_vs.json +++ b/extensions/theme-defaults/themes/dark_vs.json @@ -12,8 +12,10 @@ "activityBarBadge.background": "#007ACC", "sideBarTitle.foreground": "#BBBBBB", "input.placeholderForeground": "#A6A6A6", - "menu.background": "#303031", + "menu.background": "#252526", "menu.foreground": "#CCCCCC", + "menu.separatorBackground": "#454545", + "menu.border": "#454545", "statusBarItem.remoteForeground": "#FFF", "statusBarItem.remoteBackground": "#16825D", "ports.iconRunningProcessForeground": "#369432", diff --git a/extensions/theme-defaults/themes/light_vs.json b/extensions/theme-defaults/themes/light_vs.json index 9a5092043d986..4cd56cf46e216 100644 --- a/extensions/theme-defaults/themes/light_vs.json +++ b/extensions/theme-defaults/themes/light_vs.json @@ -13,6 +13,7 @@ "activityBarBadge.background": "#007ACC", "sideBarTitle.foreground": "#6F6F6F", "list.hoverBackground": "#E8E8E8", + "menu.border": "#D4D4D4", "input.placeholderForeground": "#767676", "searchEditor.textInputBorder": "#CECECE", "settings.textInputBorder": "#CECECE", diff --git a/src/vs/base/browser/ui/menu/menu.ts b/src/vs/base/browser/ui/menu/menu.ts index e4f1e20ffd9c6..fed53f99926e0 100644 --- a/src/vs/base/browser/ui/menu/menu.ts +++ b/src/vs/base/browser/ui/menu/menu.ts @@ -1128,6 +1128,8 @@ ${formatRule(Codicon.menuSubmenu)} height: 2em; align-items: center; position: relative; + margin: 0 4px; + border-radius: 4px; } .monaco-menu .monaco-action-bar.vertical .action-menu-item:hover .keybinding, @@ -1251,7 +1253,7 @@ ${formatRule(Codicon.menuSubmenu)} /* Vertical Action Bar Styles */ .monaco-menu .monaco-action-bar.vertical { - padding: .6em 0; + padding: 4px 0; } .monaco-menu .monaco-action-bar.vertical .action-menu-item {