Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the 'forin' code snippet in Typescript results in an eslint:recommended violation #99720

Closed
robertmassaioli opened this issue Jun 10, 2020 · 0 comments · Fixed by #99721
Closed

Using the 'forin' code snippet in Typescript results in an eslint:recommended violation #99720

robertmassaioli opened this issue Jun 10, 2020 · 0 comments · Fixed by #99721
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders javascript JavaScript support issues verified Verification succeeded
Milestone
June 2020

Comments

@robertmassaioli
Copy link
Contributor

  • VSCode Version: 1.35.0
  • OS Version: OSX 10.15.5

Steps to Reproduce:

  1. Use the 'forin' code snippet. Watch as hasOwnProperty is employed.
  2. Run eslint with eslint:recommended and watch the lint tool fail.

Does this issue occur when all extensions are disabled?: Yes
@robertmassaioli robertmassaioli mentioned this issue Jun 10, 2020
Merged
@mjbvz mjbvz self-assigned this Jun 10, 2020
@mjbvz mjbvz added the javascript JavaScript support issues label Jun 10, 2020
@mjbvz mjbvz added this to the June 2020 milestone Jun 10, 2020
@mjbvz mjbvz added verification-needed Verification of issue is requested bug Issue identified by VS Code Team member as probable bug and removed verification-needed Verification of issue is requested labels Jun 10, 2020
@RMacfarlane RMacfarlane added the verified Verification succeeded label Jul 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders javascript JavaScript support issues verified Verification succeeded
Projects
None yet
Milestone
June 2020
Development

Successfully merging a pull request may close this issue.

Update for-in loop to work with eslint:recommended robertmassaioli/vscode
4 participants
@robertmassaioli @RMacfarlane @mjbvz and others