Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping open file history #9304

Closed
rtorr opened this issue Jul 14, 2016 · 10 comments
Closed

Keeping open file history #9304

rtorr opened this issue Jul 14, 2016 · 10 comments
Assignees
Labels
*question Issue represents a question, should be posted to StackOverflow (VS Code)

Comments

@rtorr
Copy link

rtorr commented Jul 14, 2016

So, one thing I really liked about 1.2 and prior, is files did not belong to an "editor" (pane). It was one of my favorite things about vscode. I can open and close editors when ever I want. Sometimes something is not relevant or I want more room for one file, so I will close other editors. Keeping files and editors separate lets you move around your codebase without worrying about losing history. I thought this was a bug at first, since I have both tabs and "open editors" hidden in the UI as I don't need or use them.

Via twitter I heard these new split editor features were wildly requested. Feature requests are easy to make, but its hard to vote on keeping a feature that you already like.

My suggestion would be to keep the awesome work you did with tabs, but maybe store all open files in a single list also. So any time you open a file, it gets pushed to that list, while also being associated to and editor for tabs and what not.

Thoughts?

<3

  • VSCode Version:
    1.3
  • OS Version:
    OSX
@bpasero
Copy link
Member

bpasero commented Jul 15, 2016

Read and follow Ctrl+Tab to navigate in entire editor history in #6605

@bpasero bpasero closed this as completed Jul 15, 2016
@bpasero bpasero added the *question Issue represents a question, should be posted to StackOverflow (VS Code) label Jul 15, 2016
@rtorr
Copy link
Author

rtorr commented Jul 15, 2016

@bpasero

Can you have all editors closed and still have unsaved files/have edit history? I'm not sure your suggestion even relates to the feature I feel is now missing.

@bpasero
Copy link
Member

bpasero commented Jul 15, 2016

@rtorr that in particular you cannot do anymore, closing a dirty file and having it floating around is gone. We have no intent to bring this behaviour back nor make it configurable.

@rtorr
Copy link
Author

rtorr commented Jul 15, 2016

I really appreciate you taking the time fore the reply. On last note to think about and does not need a reply but is just feedback; The new open files list in editors on that replaces working files duplicates the functionality of open tabs, and it's hard to see how it is better than working files. Just saying I think you had it right the first time.

Thanks again! Keep up the awesome work (sincerely) :)

@rtorr
Copy link
Author

rtorr commented Jul 15, 2016

The biggest pain point I have with this is I have to remember what file is in what editor/pane so I don't lose undo functionality

@bpasero
Copy link
Member

bpasero commented Jul 15, 2016

Can you explain how that is a problem by an example?

@rtorr
Copy link
Author

rtorr commented Jul 15, 2016

I viewed editors as temporary. I would open and close them as I need context of 1-3 files, not assuming I need the editor open for the life of a file. Open an editor/file, make some changes, close. Reopen said file in any editor and still have undo history if needed. Prior to this release, vscode viewed editors as a view to a file, not own it's lifecycle. That is what the now removed working files drop down did. I used the 'recent files' fuzzy finder as my goto for "working files".

@rtorr
Copy link
Author

rtorr commented Jul 15, 2016

If I have both tabs and 'open editors' hidden (which I do because I don't use them in favor of recent files fuzzy finder), I have no context to when I'm going to lose file history

@bpasero
Copy link
Member

bpasero commented Jul 15, 2016

We are working on a fix to keep the undo history even after closing the editor, so we are aware of this particular issue.

@rtorr
Copy link
Author

rtorr commented Jul 15, 2016

Awesome!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*question Issue represents a question, should be posted to StackOverflow (VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants