Outline view is missing the keyboard command to just move the editor to the current a symbol

[chrisjj]

1 In Outline View, mouse-click on a symbol e.g,.

2 See the editor moves to that symbol
3 Press Down Arrow to move to another symbol.
4 Try to find a keypress that just moves the editor to that symbol.

Expected: success
Observed: failure, here. There's none I can find by experiment or reading docs. The nearest is Enter, but that also switches focus away.

Check the Command Palette. Neither this or any other commands to operate Outline View are present.

V1.42.1 on Windows.

[lambainsaan]

@jrieken I am working on this.

[jrieken]

code pointer:

vscode/src/vs/workbench/contrib/outline/browser/outlinePane.ts

Line 580 in a1f61fd

this._revealTreeSelection(newModel, first, focus, aside);

Something similar for focus events is needed

[bpasero]

Verification: bind a key to the new list.selectAndPreserveFocus command to verify this ask.

[isidorn]

This does not really work in Outline, however it works just fine in other views. For example in the References view and the explorer. In outline the focus still gets passed even when executing list.selectAndPreserveFocus command.
However since the original ask was for Outline I am reopening this.

[bpasero]

@jrieken the only reason this does not work is this code:

vscode/src/vs/workbench/contrib/outline/browser/outlinePane.ts

Line 567 in 85d3eb2

this._revealTreeSelection(newModel, e.element, !e.editorOptions.preserveFocus || !!e.editorOptions.pinned, e.sideBySide);

If I remove || !!e.editorOptions.pinned it works fine. What is the rationale?

[jrieken]

What is the rationale?

idk @joaomoreno added this via bb5b4e9

[joaomoreno]

Yeah definitely an issue with bb5b4e9

With the fix, list.selectAndPreserveFocus should now work.

[bpasero]

Thanks!