Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet balanceOut doesn't work in TSX with generics #87608

Closed
andreyvital opened this issue Dec 23, 2019 · 3 comments
Closed

Emmet balanceOut doesn't work in TSX with generics #87608

andreyvital opened this issue Dec 23, 2019 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) emmet Emmet related issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@andreyvital
Copy link

Version: 1.40.2
Commit: f359dd69833dd8800b54d458f6d37ab7c78df520
Date: 2019-11-25T14:52:45.129Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 17.7.0

Working fine:
Kapture 2019-12-23 at 14 28 38

Doesn't work:
Kapture 2019-12-23 at 14 29 59

Code:

import { NextPage } from "next";

interface IIndexProps {
  timeStamp: number;
}

const Index: NextPage<IIndexProps> = () => (
  <div>
    <div>
      <div>
        <p>
          Balance out doesn't work
        </p>
      </div>

      <span>Lorem ipsum dolor sit amet.</span>
    </div>
  </div>
);
@vscodebot vscodebot bot added the emmet Emmet related issues label Dec 23, 2019
@octref octref added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Jan 8, 2020
@octref octref added this to the Backlog milestone Jan 8, 2020
@octref
Copy link
Contributor

octref commented Jan 8, 2020

Note that you can use Expand Selection command, which is supported by TypeScript language server. Emmet doesn't handle this yet.

@andreyvital
Copy link
Author

Yes, but it doesn't select in between tags :(

@rzhao271
Copy link
Contributor

Closing in favour of #99896
Another related issue is #77279

@rzhao271 rzhao271 added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 17, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2021
@rzhao271 rzhao271 removed this from the Backlog milestone Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) emmet Emmet related issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants