Integrated terminal width too narrow #86425

Mellbourn · 2019-12-05T20:13:19Z

VSCode Version: 1.41.0-insider
OS Version: macOS Catalina version 10.15.1

Steps to Reproduce:

start Visual Studio Code Insiders 1.41.0
Toggle the integrated terminal
When the terminal has started, it is narrower than the full width available. A very noticeable gap is visible to the right of the terminal. The problem is worse the more horizontal width available.

This behaviour is new in 1.41.0-insider. 1.40.2 does not have the problem.

Does this issue occur when all extensions are disabled?: Yes

vscodebot · 2019-12-05T20:13:25Z

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

Support fixed width terminal windows (#74501)

Tyriar · 2019-12-07T00:16:58Z

Can you share your settings?

Mellbourn · 2019-12-07T15:55:42Z

Absolutely. My Code settings are synced to this gist https://gist.github.com/Mellbourn/2cb4e0da308c4bb3b086d64370238de7
My other macOS settings files are here https://github.com/Mellbourn/dotfiles

I have tested running VS Code Insiders without my VS Code settings, and the problem is still there, though not as pronounced.

The width of the gap seems to vary with the font used. Fira Code is worst (widest gap). Then Menlo, and finally Cascadia Code is the least bad. terminal.integrated.fontSize also matters.

But I have now discovered that the most important settings is terminal.integrated.rendererType. I usually set it to canvas, because it is faster for me than dom, but now I see that the problem disappears completely if I set it to dom.

gwojan · 2019-12-12T01:27:53Z

I can confirm the same behavior on a brand new install of VSCode Insiders:

Version: 1.41.0-insider (user setup)
Commit: 9579eda04fdb3a9bba2750f15193e5fafe16b959
Date: 2019-12-10T21:44:16.632Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.14393

No extensions are installed and the renderer is set to either auto or canvas.

mcpower · 2019-12-15T01:45:28Z

I can also confirm this behaviour on my existing Stable install:

Version: 1.41.0 (user setup)
Commit: 9579eda04fdb3a9bba2750f15193e5fafe16b959
Date: 2019-12-11T18:37:42.077Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18362

and a clean Insiders install:

Version: 1.42.0-insider (user setup)
Commit: cbeff45f80213db0ddda2183170281ed97ed3b12
Date: 2019-12-13T07:08:57.560Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18362

The problem persists with terminal.integrated.rendererType set to auto, canvas and experimentalWebgl. dom does not exhibit this behaviour.

All other renderers seem to be more compact than the dom renderer. For example, here is it set to auto:

and here is it set to dom:

The terminal width (in characters) seems to be the same, but non-dom renderers render characters more compactly than dom, resulting in the space on the right.

Tyriar · 2019-12-30T18:22:29Z

Copied over from #87153 (comment)

Note that this depends on the renderer being used, the char width differs between dom and the others and we use the dom sizing to determine the size as it's the widest. Since renderers aren't changed much I guess we should do a resize to fix this up.

This is blocked on an upstream API to pull char dimensions xtermjs/xterm.js#702

leseb · 2020-03-09T09:09:58Z

@Tyriar thanks for pointing out the external issue, which unfortunately doesn't seem to be making much progress. Is there anything we can do to mitigate that behavior when using canvas? dom is rather slow and resource-intensive :-(

Thanks.

nvmnghia · 2020-03-18T15:13:47Z

Lubuntu user here, same issue. canvas and experimentalWebGl have this bug. dom renderer fixes this, but it is slower.

leseb · 2020-03-18T20:31:07Z

There is no way I'm moving back to dom, it's way too slow :-(.
However, I've noticed that setting an even number for the integrated terminal font size mitigates the behavior. For instance, I've set 12 instead of 13 and it's much better.

It's not perfect but I hope that helps until we really fix this issue.
Thanks!

nvmnghia · 2020-03-19T12:15:01Z

There is no way I'm moving back to dom, it's way too slow :-(.
However, I've noticed that setting an even number for the integrated terminal font size mitigates the behavior. For instance, I've set 12 instead of 13 and it's much better.

It's not perfect but I hope that helps until we really fix this issue.
Thanks!

Can confirm :). This is getting hilarious 💯

5P5 · 2020-04-03T00:31:42Z

1.43.0
78a4c91
x64
Win10

can confirm bug

However, I've noticed that setting an even number for the integrated terminal font size mitigates the behavior. For instance, I've set 12 instead of 13 and it's much better.

this is really ridiculous; however size 12 reduces that padding 😃

Luxcium · 2020-04-05T12:05:20Z

I just played with my settings and I get the worse result when "terminal.integrated.fontSize": 18 and "window.zoomLevel": -1 I also would like to be able to set both margins (or pading probably)

JacksonKearl · 2020-04-05T16:39:01Z

Bot wasn't happy with the latest Insiders release being on a separate branch. Fixed and retriggered. With luck, this will be automatically commented upon when Insiders goes back to master (and thus this gets shipped).

🤞

Luxcium · 2020-04-07T10:01:20Z

Should it be fixed now ?? it does not do what I was hoping for ...

Version: 1.44.0-insider
Commit: 15297a9
Date: 2020-04-06T21:40:56.222Z (12 hrs ago)
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.7.0

Luxcium · 2020-04-07T10:09:53Z

@Tyriar Please tell me what to do
Either it messes with my icons using "terminal.integrated.rendererType": "dom" or it messes with the padding/margins using "terminal.integrated.rendererType": "canvas"...

Version: 1.44.0-insider
Commit: 15297a9a4ee8d611d37f48cb59c33b3cb6145c70
Date: 2020-04-06T21:40:56.222Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.7.0

Tyriar · 2020-04-07T13:07:56Z

@Luxcium it's fixed when an insider's build goes out based on master. We're about to release stable though so that will be a few days to a week before that happens. It should work in the first 1.45.0-insider version.

Luxcium · 2020-04-09T02:21:51Z

@Luxcium it's fixed when an insider's build goes out based on master. We're about to release stable though so that will be a few days to a week before that happens. It should work in the first 1.45.0-insider version.

I would like to be more fluent (professional) at doing stuff at your level and to be able to understand the workflow of your projects to be able to contribute... Many times I have ideas but don't know how to implement them so I am not wasting your time by opening Feature Request issues...

Very interesting to have access to such a nice workflow, even to a layman. I would like to be more up to the game I feel like playing soccer in my backyard, you are the ultimate football team players, the only difference is I can't have posters of my favorite players because it would be awkward to have a picture of you Daniel(@Tyriar) and Matt (@mjbvz) on the walls of my room... Probably I could have one of Anders Hejlsberg (@ahejlsberg)

(Sorry for this unrelated comment but it's my way of telling you to keep up with your great work, you guys, and obviously also all the other team members I didn't mention for both VS CODE and TypeScript)

Luxcium · 2020-04-10T11:26:51Z

hello @Tyriar it's annoying me again 😄I say annoying because I will probably still be sending a message that doesn't seem to be constructive... I understand that it is not helping you but I am just curious (also it's not a big deal for me in fact. But let's say its a 'deal' for me a small one but yeah ...)

I did cmd+a to select the area of the terminal and did a screen capture:

Version: 1.45.0-insider
Commit: c12bd56a8886f31e353a45f5846f0a35a52f908e
Date: 2020-04-10T05:39:20.415Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.7.0

Tyriar · 2020-04-10T12:25:41Z

@Luxcium can you share your settings? Works fine for me on Windows and Mac.

github-actions · 2020-04-10T14:24:29Z

This bug has been fixed in to the latest release of VS Code Insiders!

@Mellbourn, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version c12bd56 of Insiders (today's or later - you can use Help: About in the command pallete to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

Luxcium · 2020-04-21T06:06:17Z

Removed all my settings and I have no problem anymore

{
    "editor.fontSize": 18,
    "window.zoomLevel": -1,
      "terminal.integrated.fontSize": 16,
      "terminal.integrated.fontFamily": "Monofur NF,TerminessTTF NF",
    "terminal.integrated.rendererType": "canvas"
}

Luxcium · 2020-04-21T06:12:14Z

sorry (I feel bad now): // "terminal.integrated.letterSpacing": 1, is the bad boy

{
// ...
        "terminal.integrated.fontSize": 16,
        "terminal.integrated.fontFamily": "Monofur NF,TerminessTTF NF",
        "terminal.integrated.rendererType": "canvas",
        "terminal.external.osxExec": "iterm2.app",
        "terminal.integrated.copyOnSelection": true,
        "terminal.integrated.cursorBlinking": true,
        "terminal.integrated.cursorStyle": "line",
        "terminal.integrated.enableBell": true,
        "terminal.integrated.experimentalUseTitleEvent": true,
        // "terminal.integrated.letterSpacing": 1,
        "terminal.integrated.lineHeight": 1,
        "terminal.integrated.scrollback": 10000,
        "terminal.integrated.shell.osx": "/usr/local/bin/zsh",
        "terminal.integrated.showExitAlert": true,
        "code-runner.runInTerminal": true,
        "terminal.integrated.shellArgs.osx": [
    "-l",
    "-i"
  ],
// ...
}

Tyriar · 2020-04-21T10:35:33Z

@Luxcium thanks can repro. Not sure why you'd be sorry about finding a bug that I can now fix for all users?

github-actions · 2020-04-22T14:24:29Z

This bug has been fixed in to the latest release of VS Code Insiders!

@Mellbourn, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version 9328b32 of Insiders (today's or later - you can use Help: About in the command pallette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

Mellbourn · 2020-04-22T14:57:53Z

/verified

vscodebot bot added the terminal General terminal issues that don't fall under another label label Dec 5, 2019

Mellbourn changed the title ~~terminal width too narrow in integrated terminal~~ integrated terminal width too narrow Dec 5, 2019

Mellbourn changed the title ~~integrated terminal width too narrow~~ Integrated terminal width too narrow Dec 5, 2019

octref assigned Tyriar Dec 6, 2019

Tyriar added the info-needed Issue requires more information from poster label Dec 7, 2019

dbi1463 mentioned this issue Dec 19, 2019

Terminal not full width #87306

Closed

Tyriar mentioned this issue Dec 30, 2019

Unexpected terminal right padding space #87153

Closed

Tyriar added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Dec 30, 2019

Tyriar mentioned this issue Jan 7, 2020

The terminal panel have extra margin-right when vertical layout #88193

Closed

Tyriar mentioned this issue Feb 3, 2020

LESS behavior is wrong with Git Bash integration #89810

Closed

Tyriar mentioned this issue Mar 13, 2020

Support fixed width terminal windows #74501

Closed

Tyriar mentioned this issue Apr 3, 2020

Terminal view port is cropped #94320

Closed

Tyriar added this to the April 2020 milestone Apr 5, 2020

Tyriar closed this as completed in 5b0460a Apr 5, 2020

Tyriar added the author-verification-requested Issues potentially verifiable by issue author label Apr 5, 2020

JacksonKearl added author-verification-requested Issues potentially verifiable by issue author and removed author-verification-requested Issues potentially verifiable by issue author labels Apr 5, 2020

github-actions bot added the awaiting-insiders-release label Apr 5, 2020

github-actions bot removed the awaiting-insiders-release label Apr 10, 2020

Tyriar reopened this Apr 21, 2020

Tyriar closed this as completed in 01ee80d Apr 21, 2020

github-actions bot added awaiting-insiders-release and removed awaiting-insiders-release labels Apr 21, 2020

isidorn added the verified Verification succeeded label Apr 30, 2020

github-actions bot locked and limited conversation to collaborators Jun 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrated terminal width too narrow #86425

Integrated terminal width too narrow #86425

Mellbourn commented Dec 5, 2019 •

edited

Loading

vscodebot bot commented Dec 5, 2019

Tyriar commented Dec 7, 2019

Mellbourn commented Dec 7, 2019 •

edited

Loading

gwojan commented Dec 12, 2019

mcpower commented Dec 15, 2019 •

edited

Loading

Tyriar commented Dec 30, 2019 •

edited

Loading

leseb commented Mar 9, 2020

nvmnghia commented Mar 18, 2020 •

edited

Loading

leseb commented Mar 18, 2020

nvmnghia commented Mar 19, 2020

5P5 commented Apr 3, 2020

Luxcium commented Apr 5, 2020 •

edited

Loading

JacksonKearl commented Apr 5, 2020 •

edited

Loading

Luxcium commented Apr 7, 2020

Luxcium commented Apr 7, 2020 •

edited

Loading

Tyriar commented Apr 7, 2020

Luxcium commented Apr 9, 2020 •

edited

Loading

Luxcium commented Apr 10, 2020

Tyriar commented Apr 10, 2020

github-actions bot commented Apr 10, 2020

Luxcium commented Apr 21, 2020

Luxcium commented Apr 21, 2020 •

edited

Loading

Tyriar commented Apr 21, 2020

github-actions bot commented Apr 22, 2020

Mellbourn commented Apr 22, 2020

Integrated terminal width too narrow #86425

Integrated terminal width too narrow #86425

Comments

Mellbourn commented Dec 5, 2019 • edited Loading

vscodebot bot commented Dec 5, 2019

Tyriar commented Dec 7, 2019

Mellbourn commented Dec 7, 2019 • edited Loading

gwojan commented Dec 12, 2019

mcpower commented Dec 15, 2019 • edited Loading

Tyriar commented Dec 30, 2019 • edited Loading

leseb commented Mar 9, 2020

nvmnghia commented Mar 18, 2020 • edited Loading

leseb commented Mar 18, 2020

nvmnghia commented Mar 19, 2020

5P5 commented Apr 3, 2020

Luxcium commented Apr 5, 2020 • edited Loading

JacksonKearl commented Apr 5, 2020 • edited Loading

Luxcium commented Apr 7, 2020

Luxcium commented Apr 7, 2020 • edited Loading

Tyriar commented Apr 7, 2020

Luxcium commented Apr 9, 2020 • edited Loading

Luxcium commented Apr 10, 2020

Tyriar commented Apr 10, 2020

github-actions bot commented Apr 10, 2020

Luxcium commented Apr 21, 2020

Luxcium commented Apr 21, 2020 • edited Loading

Tyriar commented Apr 21, 2020

github-actions bot commented Apr 22, 2020

Mellbourn commented Apr 22, 2020

Mellbourn commented Dec 5, 2019 •

edited

Loading

Mellbourn commented Dec 7, 2019 •

edited

Loading

mcpower commented Dec 15, 2019 •

edited

Loading

Tyriar commented Dec 30, 2019 •

edited

Loading

nvmnghia commented Mar 18, 2020 •

edited

Loading

Luxcium commented Apr 5, 2020 •

edited

Loading

JacksonKearl commented Apr 5, 2020 •

edited

Loading

Luxcium commented Apr 7, 2020 •

edited

Loading

Luxcium commented Apr 9, 2020 •

edited

Loading

Luxcium commented Apr 21, 2020 •

edited

Loading