Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Allow to edit the left hand side of a diff editor if possible #85226

Closed
2 tasks done
bpasero opened this issue Nov 20, 2019 · 3 comments
Closed
2 tasks done

Test: Allow to edit the left hand side of a diff editor if possible #85226

bpasero opened this issue Nov 20, 2019 · 3 comments
Assignees
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Nov 20, 2019

Refs: #4180

Complexity: 2

  • turn auto save off
  • bring up a diff editor with editable left hand side (e.g. compare 2 files from explorer, or Search & Replace preview from search viewlet)
  • verify you can make changes on the left and right hand side
  • verify that you can save both sides e.g. via CtrlCmd+S
  • verify you cannot type into a readonly diff editor (e.g. from SCM view)
  • file issues if you get confused at one point about that experience

Note: it is currently "as designed" that the left hand editor opens as a separate tab once you start editing it because the left hand editor itself does not participate in the dirty editor experience (e.g. you are not getting asked to save 2 files when you close the diff editor and have made changes to both sides).

@bpasero bpasero added this to the November 2019 milestone Nov 20, 2019
@sbatten sbatten assigned octref, dbaeumer, eamodio and alexdima and unassigned dbaeumer and octref Dec 3, 2019
@alexdima alexdima removed their assignment Dec 3, 2019
@eamodio
Copy link
Contributor

eamodio commented Dec 3, 2019

Looks good -- tested on Windows

@eamodio eamodio closed this as completed Dec 3, 2019
@moshfeu
Copy link
Contributor

moshfeu commented Dec 22, 2019

It's open the left file in a new editor tab. I'm not sure that this is the optimal UX.

video1

@bpasero
Copy link
Member Author

bpasero commented Dec 27, 2019

As designed, otherwise we would need to show a combined save dialog when you close the editor and both sides are dirty. This solution is a good balance to keep as much of the expected behaviour as possible.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants