Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown: make a pass over languages that depend on markdown #83633

Closed
bpasero opened this issue Oct 30, 2019 · 9 comments
Closed

Markdown: make a pass over languages that depend on markdown #83633

bpasero opened this issue Oct 30, 2019 · 9 comments
Assignees
Labels
debt Code quality issues perf
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Oct 30, 2019

Extracted from #77990 there are other languages that - when opened - will drag in all of our languages via the markdown dependency.

@mjbvz
Copy link
Collaborator

mjbvz commented Oct 30, 2019

Known built-in grammars that include text.html.markdown:

@bpasero
Copy link
Member Author

bpasero commented Oct 31, 2019

I think also:

  • PHP
  •  Perl

Show more loading activity than other languages.

@bpasero
Copy link
Member Author

bpasero commented Oct 31, 2019

//cc @alexr00

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 2, 2019

@bpasero Do the php and perl grammars pull in the markdown grammar too? I see that the references a few other languages but not markdown

@bpasero
Copy link
Member Author

bpasero commented Nov 3, 2019

@mjbvz I basically just printed which grammars are being loaded here:

readFile: (resource: URI) => this._extensionResourceLoaderService.readExtensionResource(resource)

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 7, 2019

Root cause of all of this is microsoft/vscode-textmate#106

We should investigate just how painful fixing the root cause of this issue would be. A few reasons why:

  • Markdown files will still have this issue. MD files are found in a large number of repos.
  • Many grammars are effected by the same issue. Markdown is just an extreme case of the problem

@alexr00
Copy link
Member

alexr00 commented Dec 2, 2019

@mjbvz what needs to be done for this?

@mjbvz mjbvz modified the milestones: November 2019, December 2019 Dec 5, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Dec 5, 2019

Moving to December. Let's first test to see if these languages trigger the slow loading in the first place. If a language is effected, we can investigate how complicated a fix would be and if it would introduce significant regressions in the grammar

@mjbvz mjbvz modified the milestones: January 2020, February 2020 Jan 27, 2020
@mjbvz mjbvz modified the milestones: February 2020, March 2020 Feb 27, 2020
@mjbvz mjbvz modified the milestones: March 2020, April 2020 Mar 31, 2020
@mjbvz mjbvz modified the milestones: April 2020, Backlog Apr 30, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 15, 2020

Closing this snowplow issue as I'm not sure what action to take. If we see performance issues again, I suggest we look into microsoft/vscode-textmate#106 to address this

@mjbvz mjbvz closed this as completed Oct 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues perf
Projects
None yet
Development

No branches or pull requests

3 participants