-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown: make a pass over languages that depend on markdown #83633
Comments
Known built-in grammars that include |
I think also:
Show more loading activity than other languages. |
//cc @alexr00 |
@bpasero Do the php and perl grammars pull in the markdown grammar too? I see that the references a few other languages but not markdown |
@mjbvz I basically just printed which grammars are being loaded here:
|
Root cause of all of this is microsoft/vscode-textmate#106 We should investigate just how painful fixing the root cause of this issue would be. A few reasons why:
|
@mjbvz what needs to be done for this? |
Moving to December. Let's first test to see if these languages trigger the slow loading in the first place. If a language is effected, we can investigate how complicated a fix would be and if it would introduce significant regressions in the grammar |
Closing this snowplow issue as I'm not sure what action to take. If we see performance issues again, I suggest we look into microsoft/vscode-textmate#106 to address this |
Extracted from #77990 there are other languages that - when opened - will drag in all of our languages via the markdown dependency.
The text was updated successfully, but these errors were encountered: