Terminal settings per OS not alligned with rest of vscode

[isidorn]

#8222

1. Open settings.json and checkout terminal settings
2. Notice how there are 3x some settings for each OS
3. This is not alligned with rest of vscode (tasks.json, launch.json) where a user can specify an OS as field of a setting. By doing this we will not have so many settings for the terminal which will make it more compact and easier to read.

e.g

 "terminal.integrated.shell": {
  "osx": "lala",
  "linux": "asdasd"
}

[Tyriar]

Requesting feedback @Microsoft/vscode

What is the ideal format for the settings? 👍 the comment you like if you can't be bothered talking 😃

[Tyriar]

Option 1

What is currently done:

{
  "terminal.integrated.shell.linux": "bash",
  "terminal.integrated.shellArgs.linux": ["-l"]
}

[Tyriar]

Option 2

"terminal.integrated.shell": {
  "linux": "bash"
}
"terminal.integrated.shellArgs": {
  "linux": ["-l"]
}

[Tyriar]

Option 3

Put both the shell executable and args into OS key:

"terminal.integrated.shell": {
  "linux": {
    "exec": "bash",
    "args": ["-l"],
  }
}

[Tyriar]

Option 4

Hybrid of Option 2 and 3, where the os key can take either a string (the executable), or an object (the executable and optionally the args array).

"terminal.integrated.shell": {
  "linux": {
    "shell": "bash",
    "args": ["-l"],
  },
  "osx": "bash"
}

[egamma]

Settings are different from launch.json and task.json and we intentionally made them as flat as possible so Option 1 is consistent with the existing practice.

[Tyriar]

Closing as designed, we want to keep settings as flat as possible.