Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much empty space between terminal header and first line #8310

Closed
isidorn opened this issue Jun 28, 2016 · 2 comments
Closed

Too much empty space between terminal header and first line #8310

isidorn opened this issue Jun 28, 2016 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 28, 2016

#8222

@Tyriar all the bugs I file are on mac and insiders vscode.

IMHO there is too much space between the terminal header and the first line, I would expect this to be more compact - especially since most of the time the vertical space is very limited.

screen shot 2016-06-28 at 12 45 04

@isidorn isidorn added the terminal General terminal issues that don't fall under another label label Jun 28, 2016
@Tyriar
Copy link
Member

Tyriar commented Jun 28, 2016

Possibly related: #8219, xtermjs/xterm.js#149

@Tyriar Tyriar added this to the July 2016 milestone Jun 28, 2016
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Jun 29, 2016
@Tyriar
Copy link
Member

Tyriar commented Jul 5, 2016

Closing in favor of #8219, there typically be a gap as the terminal is aligned to the bottom, it would look wonky if it was aligned to the top too and resizing would look even worse imo. Verifying all lines/characters are the same height in #8219 will make the row/col calculation fit as good as possible.

@Tyriar Tyriar closed this as completed Jul 5, 2016
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Jul 5, 2016
@Tyriar Tyriar removed this from the July 2016 milestone Jul 5, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

2 participants