Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen cheese when close all to the right #8241

Closed
isidorn opened this issue Jun 28, 2016 · 6 comments
Closed

Screen cheese when close all to the right #8241

isidorn opened this issue Jun 28, 2016 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded workbench-tabs VS Code editor tab issues

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 28, 2016

#7854

  • VSCode Version: insiders
  • OS Version: os x

Steps to Reproduce:

In the second editor group:

  1. open two tabs
  2. open two / three more untitled tabs by double clicking on margin
  3. second tab context menu -> close all to the right
  4. I get screen cheese

Please try a couple of times since I do not repro this 100% but happens every other time..

screen shot 2016-06-28 at 09 24 02

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug workbench-tabs VS Code editor tab issues labels Jun 28, 2016
@bpasero bpasero added this to the June 2016 milestone Jun 28, 2016
@bpasero bpasero assigned isidorn and unassigned bpasero Jun 28, 2016
@bpasero
Copy link
Member

bpasero commented Jun 28, 2016

@isidorn cannot reproduce. Are you making the second tab active again or really just click in the context menu while the last untitled in the tab container is active?

@bpasero
Copy link
Member

bpasero commented Jun 28, 2016

Got it now. Only seems to happen in 2nd group.

@bpasero
Copy link
Member

bpasero commented Jun 28, 2016

Wow, actually seems like a Chrome bug.

@bpasero bpasero self-assigned this Jun 28, 2016
@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jun 29, 2016
@bpasero bpasero modified the milestones: July 2016, June 2016 Jun 29, 2016
@bpasero
Copy link
Member

bpasero commented Jun 29, 2016

Verified this is fixed with Chrome >= 51. I do not want to add hacks to force a repaint.

@isidorn
Copy link
Contributor Author

isidorn commented Jun 29, 2016

Agree - it is nothing mayor, any update in the header area fixes the issue

@bpasero bpasero modified the milestones: Backlog, July 2016 Jun 30, 2016
@bpasero bpasero closed this as completed Jul 6, 2016
@bpasero bpasero reopened this Jul 8, 2016
@bpasero bpasero modified the milestones: August 2016, July 2016, Backlog Jul 8, 2016
@bpasero bpasero added this to the September 2016 milestone Sep 16, 2016
@bpasero bpasero removed this from the Backlog milestone Sep 16, 2016
@bpasero
Copy link
Member

bpasero commented Sep 19, 2016

I think our Electron update fixed this.

@bpasero bpasero closed this as completed Sep 19, 2016
@isidorn isidorn added the verified Verification succeeded label Sep 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

2 participants