Option to invert terminal search direction

[probablykasper]

In VSCode 1.37, searching in the terminal was changed so that pressing enter searches backwards in the terminal. I could not find an option to change it back, or a way to override it using keyboard shortcuts, so here's a feature request for it.

[Tyriar]

@rebornix did you say you were going to add commands for these?

[rebornix]

yes, I was thinking about adding following things to allow users to decide what keybindings to use

• context keys for find input box
• commands for navigating through history in the input box

It may come together with #15727 and if the solution is simple, I'll make it generic.

[rebornix]

One thing I'm not sure about yet is whether we should have dedicated context keys for editor find, terminal find and Webviews, or we should only have a generic one and uses can use other context keys like editorFocus to differentiate the container.

[Tyriar]

@rebornix the terminal already has separate context keys and it's default behavior needs to be inverted.

[rebornix]

Fixed in master. With next Insiders, you should be able to revert the keybindings by adding following into your keybindings.json

{
        "key": "shift+enter",
        "command": "workbench.action.terminal.findPrevious",
        "when": "terminalFindWidgetFocused"
    },
    {
        "key": "enter",
        "command": "-workbench.action.terminal.findPrevious",
        "when": "terminalFindWidgetFocused"
    },
    {
        "key": "enter",
        "command": "workbench.action.terminal.findNext",
        "when": "terminalFindWidgetFocused"
    },
    {
        "key": "shift+enter",
        "command": "-workbench.action.terminal.findNext",
        "when": "terminalFindWidgetFocused"
    }

[Tyriar]

@rebornix enter and shift+enter doesn't seem to work in the terminal find widget anymore?

[rebornix]

Above gif is recored in latest master, are you testing against that?

[rebornix]

Good catch actually, the keybinding was added on Windows and Linux.

[Tyriar]

08d59c4

[Tyriar]

We should verify these keybindings on all platforms just in case.

[RMacfarlane]

Verified on all platforms.