Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New notification icons are not very readable #78857

Closed
IgorKrupenja opened this issue Aug 10, 2019 · 5 comments · Fixed by #82171
Closed

New notification icons are not very readable #78857

IgorKrupenja opened this issue Aug 10, 2019 · 5 comments · Fixed by #82171
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons verified Verification succeeded workbench-notifications Notification widget issues
Milestone

Comments

@IgorKrupenja
Copy link

  • VSCode Version: 1.37
  • OS Version: macOS 10.14.5

Steps to Reproduce:

  1. Generate some notifications.

Does this issue occur when all extensions are disabled?: Yes

Result:

The new notifications icons are so thin that they are barely readable, see '!' and 'i' on the screenshot (on Macbook Pro 13'' Retina display). This is especially problematic if you have less than perfect vision.

image

Compare e.g. to these icons on Github: the borders are thin but the exclamation mark is bolder and a lot more readable.

image

@IgorKrupenja IgorKrupenja changed the title New notification icons are not very readble New notification icons are not very readable Aug 10, 2019
@miguelsolorio miguelsolorio added the icons-product Issues for in-product icons label Aug 12, 2019
@IgorKrupenja
Copy link
Author

Note that the error notification icon (red, X inside O) looks a lot better in my opinion:
image

@miguelsolorio
Copy link
Contributor

I think we can bump the size of the icon (16px => 18px) and slightly increase the size of the ! inside:

image

image

@bpasero thoughts?

@miguelsolorio miguelsolorio added the workbench-notifications Notification widget issues label Oct 7, 2019
@bpasero
Copy link
Member

bpasero commented Oct 7, 2019

@misolori everywhere or only in notifications?

@miguelsolorio
Copy link
Contributor

@bpasero only in the notifications panel. In the screenshot above you can see the comparison between the two.

@bpasero
Copy link
Member

bpasero commented Oct 7, 2019

@misolori I can check it out on a branch to give more feedback

@miguelsolorio miguelsolorio added the under-discussion Issue is under discussion for relevance, priority, approach label Oct 7, 2019
@miguelsolorio miguelsolorio added this to the October 2019 milestone Oct 7, 2019
@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Oct 28, 2019
@Tyriar Tyriar added the verified Verification succeeded label Oct 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons verified Verification succeeded workbench-notifications Notification widget issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants