Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Tag strikethrough renders strangely multicolored #78225

Closed
sbatten opened this issue Jul 30, 2019 · 2 comments
Closed

Deprecated Tag strikethrough renders strangely multicolored #78225

sbatten opened this issue Jul 30, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug languages-diagnostics Source problems reporting verified Verification succeeded
Milestone

Comments

@sbatten
Copy link
Member

sbatten commented Jul 30, 2019

Testing #78096

When a strikethrough renders over some text it can change opacity and color multiple times depending on the underlying tokens. This makes the strikethrough look bad IMO. It should be one solid color and above the underlying text.

When two diagnostics overlap, it can be even worse:
image

@jrieken jrieken added the languages-diagnostics Source problems reporting label Jul 31, 2019
@jrieken
Copy link
Member

jrieken commented Jul 31, 2019

Yeah, I agree but I am unsure if that can be achieved. We use text decorations and I believe that always picks up the foreground color. Tho, I believe in real world this will be less funky as language brains are likely only striking out single tokens/words not multiple tokens/statements.

@alexandrudima Do you have an idea how we draw the strikeout different? Some special decoration?

@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Jul 31, 2019
@jrieken jrieken added this to the July 2019 milestone Jul 31, 2019
@jrieken
Copy link
Member

jrieken commented Jul 31, 2019

Turns out that text-decoration-color exists: https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-color

@octref octref added the verified Verification succeeded label Aug 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug languages-diagnostics Source problems reporting verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants