Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overtyping not working for css pseudo-classes #78200

Closed
miguelsolorio opened this issue Jul 30, 2019 · 9 comments
Closed

Overtyping not working for css pseudo-classes #78200

miguelsolorio opened this issue Jul 30, 2019 · 9 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-autoclosing Editor automatic closing of parens / brackets / etc.
Milestone

Comments

@miguelsolorio
Copy link
Contributor

Testing #78118

Steps to reproduce

  1. Open a CSS file
  2. Use any of the pseudo-class tags that have a parenthesis (ex: nth, not, matches)
  3. Attempt to close the parenthesis
  4. 🐛 Overtyping does not work

Screen Recording 2019-07-30 at 10 11 29 AM 2019-07-30 10_16_47

VS Code version: Code - Insiders 1.37.0-insider (cf03ea3, 2019-07-30T07:10:53.695Z)
OS version: Darwin x64 18.7.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz (8 x 3100)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (0.93GB free)
Process Argv -psn_0_536707
Screen Reader no
VM 0%
Extensions (42)
Extension Author (truncated) Version
vscode-profile-switcher aar 0.3.3
chalice-icon-theme art 0.2.1
vscode-opennewinstance chr 0.0.6
bracket-pair-colorizer Coe 1.0.61
vscode-eslint dba 1.9.0
es7-react-js-snippets dsz 2.4.0
gitlens eam 9.9.1
vsc-material-theme Equ 29.2.0
prettier-vscode esb 1.9.0
vscode-pull-request-github-insiders Git 2019.7.36902
todo-tree Gru 0.0.139
rest-client hum 0.21.3
svg joc 0.1.6
all-symbol-kinds jri 0.0.1
vscode-colorize kam 0.8.11
graphql-for-vscode kum 1.15.0
git-graph mhu 1.12.1
theme-monokai-pro-vscode mon 1.1.13
vscode-scss mrm 0.6.2
vscode-azureappservice ms- 0.15.0
remote-containers ms- 0.67.0
remote-ssh ms- 0.44.2
remote-ssh-edit ms- 0.44.2
remote-ssh-explorer ms- 0.44.2
remote-wsl ms- 0.39.1
azure-account ms- 0.8.4
cpptools ms- 0.24.1
vscode-typescript-tslint-plugin ms- 1.2.2
vsliveshare ms- 1.0.614
debugger-for-chrome msj 4.11.6
vscode-gatsby-snippets nic 1.1.2
material-icon-theme PKi 3.8.1
vscode-graphql Pri 0.2.1
try-material-icon-theme raf 3.9.0
vscode-yaml red 0.4.1
code-settings-sync Sha 3.4.1
stylelint shi 0.51.0
notification-tester svi 2.1.2
ayu tea 0.18.0
sort-lines Tyr 1.8.0
markdown-all-in-one yzh 2.4.2
vscode-open-in-github ziy 1.3.6

(8 theme extensions excluded)

@sana-ajani
Copy link
Contributor

Overtyping works for me in this case. (on Windows machine)

@alexdima
Copy link
Member

@misolori I also cannot reproduce. I wonder if this reproduces when you disable all your extensions?

@alexdima alexdima added the info-needed Issue requires more information from poster label Jul 31, 2019
@miguelsolorio
Copy link
Contributor Author

This still repros after disabling all of my extensions and also tested this on Win10 with the same result.

Just to clarify what I'm seeing:

  • Typing .foo:not then hitting enter on intellisense gives you .foo:not(|)
  • When I type ".button" overtyping on the quotes work
  • Then I proceed to close the parenthesis of the :not attribute, even though it's already there and this is where the bug appears and overtyping does not work, so I end up with .foo:not(".button"))

@miguelsolorio
Copy link
Contributor Author

Here's an example on Windows when extensions are disabled and just trying to close the parenthesis when there's one already there:

Untitled 3 2019-07-31 08_16_24

@sana-ajani
Copy link
Contributor

Ah, okay. I'm able to repro that. The ending ) doesn't overtype.

@vscodebot vscodebot bot closed this as completed Aug 7, 2019
@vscodebot
Copy link

vscodebot bot commented Aug 7, 2019

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@miguelsolorio
Copy link
Contributor Author

Ping @alexandrudima 😄

@miguelsolorio miguelsolorio reopened this Aug 7, 2019
@alexdima alexdima added editor-autoclosing Editor automatic closing of parens / brackets / etc. and removed info-needed Issue requires more information from poster labels Aug 8, 2019
@alexdima
Copy link
Member

alexdima commented Aug 8, 2019

The ) in this cases comes from intellisense (not from the auto-closing feature)... that's why it is not getting overtyped... The editor overtypes only parens that got inserted via auto-closing.

@alexdima alexdima added this to the August 2019 milestone Aug 8, 2019
@alexdima
Copy link
Member

Let's track in #78975

@alexdima alexdima added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 15, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-autoclosing Editor automatic closing of parens / brackets / etc.
Projects
None yet
Development

No branches or pull requests

3 participants