files.exclude applies to findFiles() result when null provided as exclude argument

[deitry]

There is an extension which use findFiles() API:
https://github.com/matepek/vscode-catch2-test-adapter/blob/474e6c3d06f7bc3706ac8ec21cdcfa8ad1b4c35b/src/FSWatcher.ts#L101

I notice that extension could not find executables inside build/ when this folder is listed in files.exclude configuration: matepek/vscode-catch2-test-adapter#113

As documentation stated, no excludes should apply when null is provided, so developer of extension and me consider this a bug.

Tested on VSCode Stable 1.36.1

[roblourens]

This is by design, and has always been this way, but I will update the comment on the vscode.d.ts to reflect this.

[jrieken]

When undefined only default excludes will apply. When null, no search excludes will apply, but files.exclude will still apply.

@roblourens I am super confused by that and don't believe that this is by design. Wasn't #33528 about that? Re-opening for a better clarification of the issue

[roblourens]

What I said makes no sense, I was misinterpreting a comment I made in an earlier issue. There is some bug here.

[roblourens]

This is from 10c0126#diff-667e490a03391a012e309e8a660ce628R539 :( I will add tests

[jrieken]

Thanks!

[deitry]

Thank you!