Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking into editor does not properly take focus from Terminal view #7684

Closed
neandrake opened this issue Jun 15, 2016 · 3 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone

Comments

@neandrake
Copy link

neandrake commented Jun 15, 2016

  • VSCode Version: 1.2.1 (fe7f407) (note this happened on previous version as well, 1.2.0)
  • OS Version: OSX 10.11.5

Steps to Reproduce:

  1. With Terminal view open, click into terminal and type some keys, verify terminal is receiving keyboard input
  2. Using mouse, click into text editor
  3. Type keys and see that the first keyboard input goes to terminal and the rest are lost
  4. Clicking again in text editor will bring proper focus so keyboard input is directed to editor

Note: I am using the fish shell and have not tried these same steps with bash. http://fishshell.com/

Attached is a GIF where I am doing these steps. You won't be able to see that I'm typing keys after clicking to focus into editor but I am (the terminal loses its block cursor). I click twice and focus goes into editor and my typing appears.

focus

@Tyriar Tyriar added this to the June 2016 milestone Jun 15, 2016
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Jun 15, 2016
@Tyriar
Copy link
Member

Tyriar commented Jun 15, 2016

Fixed in master already, coming in v1.3.0.

@Tyriar Tyriar closed this as completed Jun 15, 2016
@Tyriar Tyriar self-assigned this Jun 15, 2016
@neandrake
Copy link
Author

Thanks - sorry Github default Issue search is for open status only

@Tyriar
Copy link
Member

Tyriar commented Jun 15, 2016

@neandrake I'm making this the "official" issue for this bug as it was fixed before reported 😛

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants