Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource labels in web have full path #76209

Closed
roblourens opened this issue Jun 26, 2019 · 4 comments
Closed

Resource labels in web have full path #76209

roblourens opened this issue Jun 26, 2019 · 4 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
July 2019

Comments

@roblourens
Copy link
Member

  • Open a folder in the web companion
  • Open a file in that folder
  • All resource labels show the full absolute path:
    image
  • They should just show the relative path inside that folder:
    image

Don't know if related to #76117
@roblourens roblourens transferred this issue from microsoft/vscode-remote-release Jun 26, 2019
@isidorn
Copy link
Contributor

isidorn commented Jun 27, 2019

My guess would be that the labelService does not properly compute relative labels because the this.contextService.getWorkspaceFolder(resource) does not return the proper results
@sandy081 what is the state of the contextService for the web. Is this method supported currently?

@isidorn isidorn added the under-discussion Issue is under discussion for relevance, priority, approach label Jun 27, 2019
@sandy081
Copy link
Member

Yes it is. I do not think there are any differences between web and remote.

@isidorn
Copy link
Contributor

isidorn commented Jun 28, 2019

Then I will have to debug and investigate more -> assigning to July so I look into this next week.

@isidorn isidorn removed the under-discussion Issue is under discussion for relevance, priority, approach label Jun 28, 2019
@isidorn isidorn added this to the July 2019 milestone Jun 28, 2019
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Jul 3, 2019
@isidorn
Copy link
Contributor

isidorn commented Jul 3, 2019

@roblourens great catch. Thanks for reporting. It should be fixed from tomorrow.

@isidorn isidorn closed this as completed in c0a9bc3 Jul 3, 2019
@lramos15 lramos15 added the verified Verification succeeded label Jul 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
July 2019
Development

No branches or pull requests
4 participants
@roblourens @isidorn @lramos15 @sandy081