Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not clear how minimap decorations are being dropped after 1000 #76130

Closed
mjbvz opened this issue Jun 25, 2019 · 2 comments
Closed

Not clear how minimap decorations are being dropped after 1000 #76130

mjbvz opened this issue Jun 25, 2019 · 2 comments
Assignees
Labels
editor-minimap Code/Text minimap widget issues *out-of-scope Posted issue is not in scope of VS Code

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 25, 2019

Testing #76030

Repo

  1. Enable minimap
  2. Open VS Code src
  3. Open yarn.lock
  4. Search version "

Bug
This produces 1315 results. However it is not clear how results are being dropped from the minimap. I feel like I just see two decorations at the very top. More are highlighted as you arrow through the results

I'd expect we show the first X results in the minimap and then start dropping them

@vscodebot vscodebot bot added the editor-minimap Code/Text minimap widget issues label Jun 25, 2019
@RMacfarlane RMacfarlane added the *out-of-scope Posted issue is not in scope of VS Code label Oct 10, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 10, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 10, 2019
@RMacfarlane
Copy link
Contributor

They use the same logic as the decorations in the overview ruler, which attempt to combine themselves in a complicated way. I'd prefer to not try to refactor this, as I don't think it's worth it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor-minimap Code/Text minimap widget issues *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

2 participants