File service: unable to move/copy same path

[isidorn]

1. Linux
2. Trigger rename a file in the explorer
3. Click anywhere else while the rename box is shown. Notice error in the console

Unable to move/copy when source path is equal or parent of target path: Error: Unable to move/copy when source path is equal or parent of target path
The issue is that the explorer calls textFileService.move(stat.resource, targetResource) where both resources are the same.
The fileService treats this as a no-op on OS X and Win. But throws on linux.

@bpasero What is the proper behavior, that it is always a no-op, or you always throw so I put a check in the action.

fyi @joaomoreno

[bpasero]

@isidorn wanna do this? I think it is somewhere here:

vscode/src/vs/workbench/services/files/common/fileService.ts

Line 645 in d813315

private async doValidateMoveCopy(sourceProvider: IFileSystemProvider, source: URI, targetProvider: IFileSystemProvider, target: URI, overwrite?: boolean): Promise<{ exists: boolean, isCaseChange: boolean }> {

[isidorn]

Yeah. I will look into this. Thanks for pointer.

[isidorn]

Decided to fix this on the explorer side - felt more natural there.
I simply do not call into your service when the resources are the same