Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output panel is really slow on web #75641

Closed
Tyriar opened this issue Jun 17, 2019 · 9 comments
Closed

Output panel is really slow on web #75641

Tyriar opened this issue Jun 17, 2019 · 9 comments
Assignees
Labels
verified Verification succeeded web Issues related to running VSCode in the web
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 17, 2019

Repro:

  1. Open web
  2. Set log level to trace
  3. Open a terminal
  4. Open output panel
  5. Switch to remote ext hots channel

10 seconds to show white text, 10 more seconds to show colored text.

image

I saw this on Windows, where the terminal environment is very large and contains heaps of npm_* variables.

@Tyriar Tyriar added the web Issues related to running VSCode in the web label Jun 17, 2019
@isidorn isidorn assigned sandy081 and unassigned isidorn Jun 18, 2019
@sandy081
Copy link
Member

@Tyriar Are you seeing same issue when you are opening a file in editor?

@sandy081 sandy081 added this to the June 2019 milestone Jun 18, 2019
@rebornix
Copy link
Member

[2019-06-18 09:49:08.411] [exthost] [debug] Terminal process launching on ext host generates 10k characters in a line on my machine and when it's being opened in the editor, you can see the same hang as well. I can't trigger the same colorization in Code Insiders so not sure yet if it's because that wasm is slow.

@rebornix
Copy link
Member

Latest master allows you to set max tokenization line length limit without reloading the workspace, which should unblock our self hosting. The next step should be looking into why onigurma-textmate performs much worse than native.

@sandy081 sandy081 removed their assignment Jun 24, 2019
@bpasero
Copy link
Member

bpasero commented Jun 27, 2019

Could #76076 be related?

@rebornix rebornix modified the milestones: June 2019, On Deck Jun 27, 2019
@bpasero
Copy link
Member

bpasero commented Oct 1, 2019

@Tyriar do you still see this?

@Tyriar
Copy link
Member Author

Tyriar commented Oct 1, 2019

It's still bad, but not as bad. The following is tokenizing ~13000 chars

image

@bpasero
Copy link
Member

bpasero commented May 14, 2020

@Tyriar with the new work from Alex, can you quickly check if this still reproduces?

@Tyriar
Copy link
Member Author

Tyriar commented May 14, 2020

So much better:

image

@Tyriar Tyriar closed this as completed May 14, 2020
@Tyriar Tyriar added the verified Verification succeeded label May 14, 2020
@bpasero
Copy link
Member

bpasero commented May 14, 2020

Thanks a lot, kudos to @alexdima for this perf gain ❤️

@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Development

No branches or pull requests

5 participants