Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet: Update Tag changes wrong tag pair in invalid HTML #73415

Closed
the-ress opened this issue May 7, 2019 · 2 comments
Closed

Emmet: Update Tag changes wrong tag pair in invalid HTML #73415

the-ress opened this issue May 7, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) emmet Emmet related issues
Milestone

Comments

@the-ress
Copy link
Contributor

the-ress commented May 7, 2019

VS Code version: Code - Insiders 1.34.0-insider (daf7142, 2019-05-06T22:08:08.969Z)
OS version: Windows_NT x64 10.0.17134

Steps to Reproduce:

  1. Create a new HTML document
  2. Type:
<form>
    <invalid>
    <span></span>
</form>
  1. Put cursor into the <span> tag
  2. Invoke "Emmet: Update Tag" command
  3. Type form

Expected result: <span> gets changed to <form> even though it's a part of an invalid HTML. (Alternatively it could do nothing and show an error.)

Actual result: <div> gets changed to <form> unexpectedly.

Related issue: #39789

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz (4 x 2496)| |GPU Status|2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|7.87GB (0.87GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|
Extensions: none

ed2a6f5e-9302-49e9-a857-8d3eb0304ab2

@chrmarti chrmarti added the emmet Emmet related issues label May 8, 2019
@octref octref added the bug Issue identified by VS Code Team member as probable bug label May 9, 2019
@octref octref added this to the Backlog milestone May 9, 2019
@rzhao271 rzhao271 modified the milestones: Backlog, On Deck Nov 10, 2020
@rzhao271
Copy link
Contributor

Merging this issue into #99896

@rzhao271 rzhao271 added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) emmet Emmet related issues
Projects
None yet
Development

No branches or pull requests

6 participants
@the-ress @octref @rzhao271 @chrmarti @ramya-rao-a and others