Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New file doesn't show in explorer after creating from path like 'folder/subfolder/file.txt' #68204

Closed
pavelkeyzik opened this issue Feb 8, 2019 · 4 comments
Closed

New file doesn't show in explorer after creating from path like 'folder/subfolder/file.txt' #68204

pavelkeyzik opened this issue Feb 8, 2019 · 4 comments
Assignees
@isidorn
Labels
file-explorer Explorer widget issues regression Something that used to work is now broken release-notes Release notes issues
Milestone
February 2019

Comments

@pavelkeyzik
Copy link

  • VSCode Version: 1.31.0
  • OS Version: Windows 10 Enterprise (1803) Build: 17134.285

Steps to Reproduce:

  1. Open explorer sidebar
  2. Click right button on the mouse
  3. Select item 'New file'
  4. Write 'folder/subfolder/file.txt'
  5. File not created?
  6. Click 'Refresh Explorer' button
  7. Oh.. I see my folders and created file

Does this issue occur when all extensions are disabled?: Yes
@vscodebot vscodebot bot added the new release label Feb 8, 2019
@joaomoreno joaomoreno added this to the February 2019 milestone Feb 8, 2019
@joaomoreno joaomoreno assigned isidorn and unassigned joaomoreno Feb 8, 2019
@joaomoreno
Copy link
Member

joaomoreno commented Feb 8, 2019 •
edited
Loading

@isidorn I believe this changed with refreshing only the parent of a new file... we should instead refresh parent of the first "new" stat in the chain.

@bpasero bpasero added file-explorer Explorer widget issues regression Something that used to work is now broken labels Feb 9, 2019
@bpasero bpasero mentioned this issue Feb 9, 2019
Closed
@vscodebot vscodebot bot removed the new release label Feb 10, 2019
@isidorn isidorn mentioned this issue Feb 18, 2019
Closed
@pavelkeyzik
Copy link
Author

Any updates of this bug?

@isidorn
Copy link
Contributor

isidorn commented Feb 20, 2019

We plan to fix it soon

@isidorn isidorn mentioned this issue Feb 22, 2019
Closed
@isidorn
Copy link
Contributor

isidorn commented Feb 27, 2019

A proper fix would be that the file service emits events all the way up to the first created resource.
However I found that too risky for endgame and due to that I only made a local change to the file actions. That if multiple resources got created we refresh the whole explorer. This is the fix I am most comfortable with, since it is user action initiated, instead of tweaking how I react on file events

@isidorn isidorn added the release-notes Release notes issues label Mar 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
file-explorer Explorer widget issues regression Something that used to work is now broken release-notes Release notes issues
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
4 participants
@joaomoreno @bpasero @isidorn @pavelkeyzik