Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"tsc watch" task broken for projects with references #66875

Closed
RomainMuller opened this issue Jan 22, 2019 · 1 comment · Fixed by #67148
Closed

"tsc watch" task broken for projects with references #66875

RomainMuller opened this issue Jan 22, 2019 · 1 comment · Fixed by #67148
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded

Comments

@RomainMuller
Copy link
Contributor

  • VSCode Version: 1.30.2
  • OS Version: macOS X 10.13.6 (17G4015)

Steps to Reproduce:

  1. Open a package with references in the tsconfig.json file
  2. Attempt to execute the tsc : watch - tsconfig.json build task
  3. Behold the tsc error (pardon my french):
    > Executing task: tsc --watch -b /Repro/tsconfig.json <
    
    error TS6369: Option '--build' must be the first command line argument.
    Le processus du terminal s'est achevé avec le code de sortie 1
    
    Le terminal sera réutilisé par les tâches, appuyez sur une touche pour le fermer.
    

Does this issue occur when all extensions are disabled?: Yes


The issue appears to be caused by the -b being added at tasks.ts:221 and --watch being prepended to that value at tasks.ts:200, resulting in an invalid invocation of tsc. A possible solution might be to append --watch at the end instead of prepending.

@vscodebot vscodebot bot added the tasks Task system issues label Jan 22, 2019
@RomainMuller
Copy link
Contributor Author

RomainMuller commented Jan 22, 2019

I have a fix for this in my fork that I should be able to push a PR for pretty soon (waiting for employee to approve the contrib).

@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jan 23, 2019
@alexr00 alexr00 added this to the February milestone Jan 23, 2019
@chrmarti chrmarti added the verified Verification succeeded label Feb 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants