-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctrl + L should be bound to clear repl by default #66302
Comments
Ctrl + L is a key chord combination and a user can enable it for any custom keybinding while also in debug console. fyi @weinand @roblourens |
@Tyriar bind Ctrl+L to clear terminal by default. Can we add this for |
ctrl+L is a common keybinding to clear shells, cmd+k is the only default keybinding to clear the terminal, ctrl+k are not defaults on LInux/Windows as it would break chords. I think it makes more sense to have ctrl+L as an option via custom keybindings since no one has requested it. |
Or, it might be that little people can discovered it.
So this would only break people who run Ctrl+L in Debug Console and intending to invoke a custom chord he has defined. I tried defining the following chord: {
"key": "ctrl+l ctrl+n",
"command": "workbench.action.focusNextGroup"
} And I already cannot invoke it in terminal. So I think it's fine to make debug console behave the same. People who really want to invoke Ctrl+L chords in terminal/debug-console can remove the builtin shortcut. |
Why are we talking about chords? ctrl+l isn't used for built-in chords is it? |
Can't any ctrl+key be a chord combination? 😕 |
afaik no, only ctrl + l and ctrl + k |
@isidorn We don't reserve/hard code keybindings for chords, i.e. any valid keybinding can be the first part of a chord. |
@alexandrudima I was unaware of that, thanks. fyi @weinand |
@octref sorry I changed my mind, since I only now figured out that we do not even use ctrl+l to clear the terminal (only now read @Tyriar comment). If we were to do something for the debug console should we use the same as the terminal or ctrl+L as you suggest. |
@isidorn We do clear terminal on Ctrl+L although it's not specified as a shortut. So does Ctrl+A/E for going to beginning/end of current command. Chrome DevTools also have it. |
Maybe you should bring it up in the UX call to see what people think? I'd be interested in seeing which editors/IDEs use this for repls. |
@octref thanks for providing more details. I am finally convinced, since we are clearing with Ctrl + L the terminal it makes sense to do this in the debug console. To verify: |
Ctrl + L should be bound to
workbench.debug.panel.action.clearReplAction
by default. This is the standard behavior on terminal.The text was updated successfully, but these errors were encountered: