Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine terminal character size in a font-agnostic way #6456

Closed
Tyriar opened this issue May 18, 2016 · 1 comment
Closed

Determine terminal character size in a font-agnostic way #6456

Tyriar opened this issue May 18, 2016 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
June 2016

Comments

@Tyriar
Copy link
Member

Tyriar commented May 18, 2016

Integrated terminal master issue: #143

The width/height of the terminal is currently based on a hard coded character size, this needs to be based on the character size in the monospace font being used.
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels May 18, 2016
@Tyriar Tyriar self-assigned this May 18, 2016
@Tyriar Tyriar mentioned this issue May 18, 2016
Closed
@Tyriar Tyriar mentioned this issue May 28, 2016
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Jun 3, 2016

Fixed in #6998, thanks @kisstkondoros!

@Tyriar Tyriar closed this as completed Jun 3, 2016
@Tyriar Tyriar added this to the June 2016 milestone Jun 3, 2016
@joaomoreno joaomoreno added the verified Verification succeeded label Sep 2, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
June 2016
Development

No branches or pull requests
2 participants
@joaomoreno @Tyriar