Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"enablePreview" setting is not discoverable #61582

Closed
weinand opened this issue Oct 23, 2018 · 7 comments
Closed

"enablePreview" setting is not discoverable #61582

weinand opened this issue Oct 23, 2018 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Oct 23, 2018

Some users don't like the fact that editors are reused if they are not "pinned" (e.g. #61569).
I know how to pin an editor by double-clicking but I had a hard time to find the corresponding setting enablePreview because "preview" isn't something I can relate to "pinning".

IMO "enablePreview" is a less-than-ideal name (but it is probably too late to change this).
I suggest to at least mention the concept "pinned" in the description of enablePreview.

If I search for "pinned" in settings I find only this (which appears to be completely bogus):
2018-10-23_10-56-20

/cc @roblourens

@RonnieLyu
Copy link

Thank you very much.!!!!!

@bpasero bpasero added the help wanted Issues identified as good community contribution opportunities label Oct 23, 2018
@bpasero bpasero added this to the October 2018 milestone Oct 23, 2018
@bpasero
Copy link
Member

bpasero commented Oct 23, 2018

PR welcome

@bpasero bpasero added the feature-request Request for new features or functionality label Oct 23, 2018
@karanisverma
Copy link
Contributor

@bpasero I would like to pick this up!
To my understanding the description need to be changed for better explanation. Please let me know If I am getting it wrong.

@bpasero
Copy link
Member

bpasero commented Oct 23, 2018

@karanisverma yeah thats about right, thanks

@karanisverma
Copy link
Contributor

Thanks @bpasero :)
current description states following:
Controls whether opened editors shows as preview. Preview editors are reused until they are kept (eg. via double click or editing) and show up with an italic font style.

I am thinking changing it to

Controls whether opened editors shows as preview. Preview editors are reused until they are pinned (eg. via double click or editing) and show up with an italic font style.

Essentially I am thinking of swapping word "kept" to "pinned".

if it sounds good, i will go ahead and create a PR for the same.

@bpasero
Copy link
Member

bpasero commented Oct 23, 2018

@karanisverma yeah thats good. Also maybe fix that typo: Controls whether opened editors show as preview. (shows => show)

@karanisverma
Copy link
Contributor

karanisverma commented Oct 23, 2018

Hey @bpasero Thanks a lot!
i will do this changes and create a PR.
(shows => show) was mistake at my end. just checked, it doesn't exist in vscode.

@bpasero bpasero closed this as completed Oct 23, 2018
@bpasero bpasero added the verification-needed Verification of issue is requested label Oct 23, 2018
@mjbvz mjbvz added the verified Verification succeeded label Oct 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants