Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-attach fails on Windows #55672

Closed
weinand opened this issue Aug 2, 2018 · 1 comment
Closed

Auto-attach fails on Windows #55672

weinand opened this issue Aug 2, 2018 · 1 comment
Assignees
@weinand
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
July 2018

Comments

@weinand
Copy link
Contributor

weinand commented Aug 2, 2018 •
edited
Loading

VS Code Insiders:

  • turn on auto-attach
  • on integrated terminal run node --inspect test.js

Observe: debugger does not automatically attach

Problem: VS Code has changed how the terminal is launched:
previously a node.js process with an identifying argument --type=terminal was used; now an executable winpty-agent.exe is used.

Since the auto-attach feature needs to identify this process, it was broken by the VS Code change.
@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Aug 2, 2018
@weinand weinand added this to the July 2018 milestone Aug 2, 2018
@weinand weinand self-assigned this Aug 2, 2018
@weinand weinand mentioned this issue Aug 2, 2018
Closed
@weinand weinand closed this as completed in 47cf060 Aug 2, 2018
@sbatten sbatten added verified Verification succeeded and removed verified Verification succeeded labels Aug 3, 2018
@sbatten
Copy link
Member

sbatten commented Aug 3, 2018

verified in sources but wasn't in latest build yet

@mjbvz mjbvz added the verified Verification succeeded label Aug 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
3 participants
@weinand @sbatten @mjbvz