Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript debugging breakpoints broke on VSCode 1.25.1 #54740

Closed
luthfianto opened this issue Jul 20, 2018 · 5 comments
Closed

TypeScript debugging breakpoints broke on VSCode 1.25.1 #54740

luthfianto opened this issue Jul 20, 2018 · 5 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues info-needed Issue requires more information from poster

Comments

@luthfianto
Copy link

luthfianto commented Jul 20, 2018

  • VSCode Version: 1.25.1
  • OS Version: macOS 10.13.4 (17E199)

Steps to Reproduce:

  1. Debug a Typescript project on VSCode 1.25.1. (Details: my project is not a frontend/webpack project)
  2. Breakpoints would be unverified despite enabled sourcemap and correctlaunch.json and
    tsconfig.json

My launch.json after I tried different configurations on 1.25.1:

        {
            "name": "LAUNCH",
            "type": "node",
            "request": "launch",
            "runtimeArgs": [
                "--nolazy"
            ],
            "envFile": "${workspaceFolder}/.env",
            "sourceMaps": true,
            "cwd": "${workspaceFolder}",
            "program": "${workspaceFolder}/start.js",
            "outFiles": [
                "${workspaceFolder}/lib/**/*.js"
            ],
            "protocol": "inspector",
            "trace": "all"
        },

on launch.json I've tried to enable normal sourcemap or inlined sourcemap, no success.

  1. Sometimes this error pops on 1.25.1 when I hit the debug launch button:

"root folders property missing"

Found no exact match on Google, seems like it's a new bug

  1. If I grep the log/trace it would show the sourcemap is found/loaded/created. But breakpoints are still unverified
SourceMap: creating for /Users/rilut/myproject/lib/components/repos/my_repo.js
SourceMaps.scriptParsed: /Users/rilut/myproject/lib/components/repos/my_repo.js was just loaded and has mapped sources: ["/components/repos/my_repo.ts"]
  1. After reading @chriscordova comment on Debugger opens incorrect file #54697 (comment) that everything are okay in 1.24.1, I decided to downgrade to VSCode 1.24.1. (Details: I open the 1.24.1 without closing the 1.25.1)

  2. Breakpoints are working in 1.24.1 even without any configurations, I still use the exact launch.json from no 2

  3. Can't re-reproduce the error on 1.25.1 because when I press debug:

Debug adapter executable '/Users/rilut/.vscode/extensions/ms-vsliveshare.vsliveshare-0.3.395/dotnet_modules/Microsoft.Cascade.VSCodeHostAdapter' does not exist.

Debug adapter executable '/Users/rilut/.vscode/extensions/ms-vsliveshare.vsliveshare-0.3.395/dotnet_modules/Microsoft.Cascade.VSCodeHostAdapter' does not exist.

@weinand
Copy link
Contributor

weinand commented Jul 20, 2018

Can you still reproduce if you disable the Liveshare extension?

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues info-needed Issue requires more information from poster labels Jul 20, 2018
@luthfianto
Copy link
Author

Yes, I can launch debug again in 1.25.1, and the Unverified Breakpoints still exist.

Which logs should I provide?

@roblourens
Copy link
Member

roblourens commented Jul 23, 2018

Can you try this in insiders? Sounds similar to #54026

@luthfianto
Copy link
Author

I can confirm breakpoints works again in Insider.

  • rm -rf lib && tsc
  • debug in 1.25.1, debugging doesn't work
  • debug in Insider, debugging works

@roblourens
Copy link
Member

Great, thanks for trying that.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants