Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Title: right clicking on title bar should show standard menu #53011

Closed
Tyriar opened this issue Jun 26, 2018 · 6 comments
Closed

Custom Title: right clicking on title bar should show standard menu #53011

Tyriar opened this issue Jun 26, 2018 · 6 comments
Assignees
@deepak1556
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 26, 2018

#52854

Right clicking should show something like this:

image
@Tyriar Tyriar added the titlebar VS Code main title bar issues label Jun 26, 2018
@sbatten
Copy link
Member

sbatten commented Jun 26, 2018

@Tyriar This should already be working. Can you provide repro steps?

@sbatten sbatten added the info-needed Issue requires more information from poster label Jun 26, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Jun 27, 2018

@sbatten right click the title bar on Linux.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 27, 2018

FYI this is the standard menu on Ubuntu 18/gnome.

image

max/min and close should be included as a minimum.

@bpasero bpasero changed the title Menu: Right clicking on title bar should show standard menu Custom title: Right clicking on title bar should show standard menu Jul 2, 2018
@bpasero bpasero changed the title Custom title: Right clicking on title bar should show standard menu Custom title: right clicking on title bar should show standard menu Jul 2, 2018
@bpasero bpasero changed the title Custom title: right clicking on title bar should show standard menu Custom Title: right clicking on title bar should show standard menu Jul 2, 2018
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Jul 3, 2018
@sbatten sbatten added this to the July 2018 milestone Jul 3, 2018
@sbatten
Copy link
Member

sbatten commented Jul 29, 2018

On windows, this works because the OS returns that menu on right-click of a draggable region. We can't listen for mouse events on a draggable region as I understand electron/electron#1354

@sbatten sbatten added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jul 29, 2018
@sbatten sbatten closed this as completed Jul 29, 2018
@ramya-rao-a ramya-rao-a reopened this Aug 2, 2018
@ramya-rao-a ramya-rao-a modified the milestones: July 2018, Backlog Aug 2, 2018
@sbatten sbatten assigned deepak1556 and unassigned sbatten Oct 9, 2019
@sbatten sbatten removed this from the Backlog milestone Oct 9, 2019
@sbatten
Copy link
Member

sbatten commented Oct 9, 2019

@deepak1556 similar to the issue with shift clicking the taskbar in windows.

@bpasero bpasero added the electron Issues and items related to Electron label Oct 10, 2019
@deepak1556 deepak1556 mentioned this issue Sep 10, 2020
Closed
@deepak1556
Copy link
Collaborator

Closing as this is a wontfix in upstream

@deepak1556 deepak1556 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bpasero @deepak1556 @Tyriar @sbatten @ramya-rao-a