Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize terminal access APIs #52574

Closed
Tyriar opened this issue Jun 21, 2018 · 5 comments
Closed

Stabilize terminal access APIs #52574

Tyriar opened this issue Jun 21, 2018 · 5 comments
Assignees
Labels
api api-finalization feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 21, 2018

These ones seem like no brainers:

export namespace window {
	/**
	 * The currently opened terminals or an empty array.
	 */
	export const terminals: ReadonlyArray<Terminal>;

	/**
	 * An [event](#Event) which fires when a terminal has been created, either through the
	 * [createTerminal](#window.createTerminal) API or commands.
	 */
	export const onDidOpenTerminal: Event<Terminal>;
}

Both live share and python are using/want to use these.

@Tyriar Tyriar added feature-request Request for new features or functionality api labels Jun 21, 2018
@Tyriar Tyriar added this to the July 2018 milestone Jun 21, 2018
@Tyriar Tyriar self-assigned this Jun 21, 2018
@Maples7
Copy link

Maples7 commented Jun 21, 2018

Great feature!

And wouldn't it be better to cd to the directory of the open focus file after the terminal is launched? I am trying to write an extension to achieve this feature but do not find the activation event while a terminal is launched. So good to know this is planned.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 21, 2018

FYI @jrieken

@Maples7
Copy link

Maples7 commented Jun 22, 2018

I've published an extension to achieve the function I mentioned above.

Terminal In Place

@Tyriar Tyriar added terminal General terminal issues that don't fall under another label api-finalization labels Jul 2, 2018
@Tyriar Tyriar changed the title Stabilize terminal APIs Stabilize all terminal access APIs Jul 2, 2018
@Tyriar Tyriar changed the title Stabilize all terminal access APIs Stabilize terminal access APIs Jul 5, 2018
@Tyriar Tyriar closed this as completed in 096d627 Jul 5, 2018
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Jul 25, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Jul 25, 2018

Verifier please make sure the APIs exist and are functional

@dziarkoaka1001
Copy link

Dzialaja należycie :)

@roblourens roblourens added the verified Verification succeeded label Aug 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api api-finalization feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants