When dragging sidebar views to rearrange, individual items in the Open Editors view are highlighted

[iansan5653]

• VSCode Version: 1.25.0-insider
• OS Version: Windows 10 Home - 1803

Steps to Reproduce:

1. Select the Explorer sidebar tab
2. Drag the Outline or File Hierarchy views as if to rearrange them
3. Move the cursor over an item in the Open Editors view
4. The individual editors will change color along with the entire view, making it seem as if you can drop a sidebar view into an open editor and something will happen. What should actually happen is that the view should highlight (since its location will be replaced; it does do this), but the individual items should not be affected.

Screenshot:

I am holding the File Hierarchy view over the index.js file in that screenshot.

Does this issue occur when all extensions are disabled?: Yes

[isidorn]

I acknowledge the issue, the problem is that the OpenEditor view is not differentiating between drag events
https://github.com/Microsoft/vscode/blob/0a35cbfcf422054090971f78cf3a357cb42c3bae/src/vs/workbench/parts/files/electron-browser/views/openEditorsView.ts#L629

PR to fix this is welcome

[iansan5653]

I was able to add a check to prevent the hover styling unless the item being dragged is another open editor in the list (see iansan5653@5add9ce), however this also means that when tabs are dragged over the Open Editors panel (ie, when there's multiple groups; you can drag a tab into a group and it will duplicate into that group), it doesn't have any styling anymore. I couldn't figure out a way to check if the dragged object is a tab. Is that feasible? Where would I look?

[isidorn]

@iansan5653 yeah it is not so simple
You would need to check the dragged data. If there is an elegent solution to fix this please provide a PR. If too complex or computation intensive I would prefer to leave the issue open for now. Thanks

[iansan5653]

@isidorn So just to make sure, the only things that should trigger the focused class on open editors are the open tabs and the other open editors in the list, correct?

[isidorn]

@iansan5653 no. Dragging resources from the explorer, adn dragging things outside of vscode should also trigger it