Reordering activity bar forces item to be visible

[mjbvz]

Issue Type: Bug

Testing #50578

Steps

1. Hide the search activity bar entry
2. Now use keyboard shortcuts to bring the search view back up
3. Notice the icon is restored while search is visible
4. Now drag the search icon in the activity bar

Bug
The search item is now always visible again. If you do not drag it, when you switch away from search the activity bar entry is automatically hidden

(PS. sorry for the nit-picky issues)

VS Code version: Code - Insiders 1.24.0-insider (bfd155e, 2018-05-29T06:13:09.810Z)
OS version: Darwin x64 17.5.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled video_decode: enabled video_encode: enabled vpx_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	3, 4, 4
Memory (System)	16.00GB (0.15GB free)
Process Argv	/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron -psn_0_1692061
Screen Reader	no
VM	0%

[sandy081]

Thanks for reporting.

Item is pinned during drag and drop. This is as per design.