Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional breakpoint prompt should offer to enable (not disable) breakpoints if breakpoint is already disabled #50569

Closed
DanTup opened this issue May 28, 2018 · 2 comments
Closed

Conditional breakpoint prompt should offer to enable (not disable) breakpoints if breakpoint is already disabled #50569

DanTup opened this issue May 28, 2018 · 2 comments
Assignees
@isidorn
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2018

Comments

@DanTup
Copy link
Contributor

DanTup commented May 28, 2018

  • Create a conditional breakpoint
  • Click on the breakpoint in the gutter to get the "Disable instead of remove?" prompt
  • Click "Disable breakpoint"
  • Click on the breakpoint again in the gutter

The dialog that pops up asks if you want to disable the breakpoint instead of removing it; but it's already disabled. It would be better to ask if the user wants to remove it or enable it since it feels quite natural to re-enable it via the path you disabled it.
@vscodebot
Copy link

vscodebot bot commented May 28, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@isidorn
Copy link
Contributor

isidorn commented May 28, 2018

This is a fair feature request and we accept PRs that fix this.
Code pointer https://github.com/Microsoft/vscode/blob/8f47ba52a023fa8e9707f805a7dc771170326e7a/src/vs/workbench/parts/debug/electron-browser/debugEditorContribution.ts#L201

@isidorn isidorn added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels May 28, 2018
@isidorn isidorn removed their assignment May 28, 2018
@isidorn isidorn added this to the Backlog milestone May 28, 2018
@isidorn isidorn mentioned this issue Jun 5, 2018
Closed
@isidorn isidorn self-assigned this Sep 21, 2018
@isidorn isidorn added the verification-needed Verification of issue is requested label Sep 21, 2018
@isidorn isidorn modified the milestones: Backlog, September 2018 Sep 21, 2018
@alexr00 alexr00 self-assigned this Sep 25, 2018
@alexr00 alexr00 added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Sep 25, 2018
@alexr00 alexr00 removed their assignment Sep 25, 2018
@isidorn isidorn added the release-notes Release notes issues label Sep 26, 2018
@alexr00 alexr00 added the verification-needed Verification of issue is requested label Sep 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
3 participants
@DanTup @isidorn @alexr00