Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename editorActiveLineNumber.foreground #46848

Closed
aeschli opened this issue Mar 28, 2018 · 1 comment
Closed

Rename editorActiveLineNumber.foreground #46848

aeschli opened this issue Mar 28, 2018 · 1 comment
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Milestone
March 2018

Comments

@aeschli
Copy link
Contributor

aeschli commented Mar 28, 2018 •
edited
Loading

editorActiveLineNumber.foreground isn't following our color name guidelines

Should be editorLineNumber.activeForeground
@aeschli aeschli self-assigned this Mar 28, 2018
@aeschli aeschli added the themes Color theme issues label Mar 28, 2018
@aeschli aeschli added this to the March 2018 milestone Mar 28, 2018
@aeschli aeschli mentioned this issue Mar 28, 2018
Closed
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Mar 29, 2018
@aeschli
Copy link
Contributor Author

aeschli commented Mar 29, 2018

Verifiers: Please verify that the old name is marked as deprecated and still works.

@RMacfarlane RMacfarlane reopened this Mar 29, 2018
@RMacfarlane RMacfarlane added the verified Verification succeeded label Mar 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
March 2018
Development

No branches or pull requests
2 participants
@RMacfarlane @aeschli