-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue reporter unresponsive for several seconds #46335
Comments
That was fast :) |
@RMacfarlane actually, upon further testing I verified that this only happens if I open a folder (File > Open Folder) for a remote directory mounted locally via SFTP (using the system's graphical file browser, in case it matters). I just tested with fully local folders, and the delay is quite tolerable (barely noticeable, even). On the other hand, with such remote folders the issue reporter window consistently takes several minutes to open. I'm not sure how this new information affects the change you made, in particular whether it would still solve this issue. I can always open a separate issue for the SFTP-related delay, it that would make more sense at this point. |
@waldyrious Ah, thanks for the additional info! I don't think my changes will fix that scenario. The reporter collects some metadata information about what types of files are in your workspace for reporting performance issues, so my suspicion is that that process is taking longer for remote files and unintentionally blocking rendering. I'll reopen this. |
Thanks, and sorry for the misleading initial description. Hopefully the commit was an improvement nevertheless :) Let me know if there's anything I can do to assist in resolving this. |
@waldyrious The issue reporter was requesting data about the workspace that was calculated synchronously, causing blocking. This data is only needed for performance issues, so I made a change to only fetch it when actually needed (f3ba860), and to calculate it asynchronously (220bf36). The first change made it into our next release which should be out tomorrow, so the issue should be fixed there for bug reports. Thanks for reporting this! |
Awesome! Thanks again for the swift resolution. ps - so it turns out this was indeed a dupe of #45163, as I suspected in the opening comment :) |
I thought this had to do with some sort of initial download, but I can reproduce this multiple times. When I click the Help > Report Issue menu entry, the Issue Reporter window starts out blank for several seconds, and the network activity graph (shown as yellow in my system monitor widget) starts spiking:
When the window finally is able to display some content (note from the timestamp at the top that it took about two minutes!), it's noticeable that the network activity also ceases:
From the title, I suspect this might be related to #44736 or #45163, but I'm not sure it's the same issue as either.
I'm on Ubuntu 16.04 LTS, using the Gnome Shell, if it matters.
The text was updated successfully, but these errors were encountered: