Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue reporter unresponsive for several seconds #46335

Closed
waldyrious opened this issue Mar 22, 2018 · 7 comments
Closed

Issue reporter unresponsive for several seconds #46335

waldyrious opened this issue Mar 22, 2018 · 7 comments
Assignees
Labels
issue-reporter Issue reporter widget issues perf verified Verification succeeded
Milestone

Comments

@waldyrious
Copy link
Contributor

waldyrious commented Mar 22, 2018

I thought this had to do with some sort of initial download, but I can reproduce this multiple times. When I click the Help > Report Issue menu entry, the Issue Reporter window starts out blank for several seconds, and the network activity graph (shown as yellow in my system monitor widget) starts spiking:

screenshot from 2018-03-22 11-56-57

When the window finally is able to display some content (note from the timestamp at the top that it took about two minutes!), it's noticeable that the network activity also ceases:

screenshot from 2018-03-22 11-58-05

From the title, I suspect this might be related to #44736 or #45163, but I'm not sure it's the same issue as either.

I'm on Ubuntu 16.04 LTS, using the Gnome Shell, if it matters.

  • VSCode Version: Code 1.21.1 (79b44aa, 2018-03-14T14:46:30.761Z)
  • OS Version: Linux x64 4.13.0-36-generic
@bpasero bpasero assigned RMacfarlane and unassigned bpasero Mar 23, 2018
@RMacfarlane
Copy link
Contributor

Thanks for reporting! I've also been able to reproduce on Ubuntu - for me there's about a 1-2 second delay on load. I've made a change to the loading js that speeds it up.

If you're curious, you can open the dev tools in that window with ctrl + shift + i.
screen shot 2018-03-23 at 2 26 51 pm

@RMacfarlane RMacfarlane added issue-reporter Issue reporter widget issues perf labels Mar 23, 2018
@RMacfarlane RMacfarlane added this to the March 2018 milestone Mar 23, 2018
@waldyrious
Copy link
Contributor Author

That was fast :)

@waldyrious
Copy link
Contributor Author

@RMacfarlane actually, upon further testing I verified that this only happens if I open a folder (File > Open Folder) for a remote directory mounted locally via SFTP (using the system's graphical file browser, in case it matters).

I just tested with fully local folders, and the delay is quite tolerable (barely noticeable, even). On the other hand, with such remote folders the issue reporter window consistently takes several minutes to open.

I'm not sure how this new information affects the change you made, in particular whether it would still solve this issue. I can always open a separate issue for the SFTP-related delay, it that would make more sense at this point.

@RMacfarlane
Copy link
Contributor

@waldyrious Ah, thanks for the additional info! I don't think my changes will fix that scenario. The reporter collects some metadata information about what types of files are in your workspace for reporting performance issues, so my suspicion is that that process is taking longer for remote files and unintentionally blocking rendering. I'll reopen this.

@RMacfarlane RMacfarlane reopened this Mar 26, 2018
@waldyrious
Copy link
Contributor Author

Thanks, and sorry for the misleading initial description. Hopefully the commit was an improvement nevertheless :)

Let me know if there's anything I can do to assist in resolving this.

@RMacfarlane RMacfarlane modified the milestones: March 2018, April 2018 Mar 29, 2018
@RMacfarlane RMacfarlane modified the milestones: April 2018, May 2018 Apr 24, 2018
@RMacfarlane
Copy link
Contributor

RMacfarlane commented May 2, 2018

@waldyrious The issue reporter was requesting data about the workspace that was calculated synchronously, causing blocking. This data is only needed for performance issues, so I made a change to only fetch it when actually needed (f3ba860), and to calculate it asynchronously (220bf36). The first change made it into our next release which should be out tomorrow, so the issue should be fixed there for bug reports.

Thanks for reporting this!

@waldyrious
Copy link
Contributor Author

waldyrious commented May 3, 2018

Awesome! Thanks again for the swift resolution.

ps - so it turns out this was indeed a dupe of #45163, as I suspected in the opening comment :)

@sbatten sbatten added the verified Verification succeeded label May 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue-reporter Issue reporter widget issues perf verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants