Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet regression: completion missing if there errors in file #44840

Closed
chrmarti opened this issue Mar 1, 2018 · 2 comments
Closed

Emmet regression: completion missing if there errors in file #44840

chrmarti opened this issue Mar 1, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone

Comments

@chrmarti
Copy link
Collaborator

chrmarti commented Mar 1, 2018

Verifying #33115

1.20.1 Shows a completion:

image

where 1.21.0-insiders doesn't:

image

Not sure if that intended.

@ramya-rao-a
Copy link
Contributor

Emmet completions have moved to the css extension in 1.21
The above content has errors and the css extension doesn't provide completions in a position that comes after a place that has errors. In this case there is error in line 3, so all css features stop there.

Closing as by design for now.
We'll see what the user reaction is.

@ramya-rao-a ramya-rao-a changed the title Emmet completion missing? Emmet completion missing if there errors in file Mar 1, 2018
@ramya-rao-a ramya-rao-a added *as-designed Described behavior is as designed emmet Emmet related issues bug Issue identified by VS Code Team member as probable bug and removed *as-designed Described behavior is as designed labels Mar 1, 2018
@ramya-rao-a
Copy link
Contributor

On second thoughts, this might not be desirable.
One advantage of emmet completions is that they work even if css completions don't.
Will revert the move to css extension until we resolve the upstream issue of the css language service not able to parse the complete document when there are errors.

@ramya-rao-a ramya-rao-a reopened this Mar 1, 2018
@ramya-rao-a ramya-rao-a added this to the February 2018 milestone Mar 1, 2018
@chrmarti chrmarti added the verified Verification succeeded label Mar 2, 2018
@ramya-rao-a ramya-rao-a changed the title Emmet completion missing if there errors in file Emmet regression: completion missing if there errors in file Mar 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants