Propose to rephrase hit count breakpoint placeholder text

[joaomoreno]

Testing #43836

I felt a bit lost when reading this:

The phrasing is a bit too generic and leaves room for interpretation on what should be input, when in fact the condition is a pure equality and the value should be a number. Here's a suggestion:

Break when hit X times. Please input a number, 'Enter' to accept, 'Escape' to cancel.

[isidorn]

This make sense to me.
I am wondering if some other debug adapters use the hit count in a different way thus we choose a more generic message.
@weinand what are your thoughts?

[weinand]

The syntax is not specified as it depends on the backend:
generic doc: https://code.visualstudio.com/docs/editor/debugging#_conditional-breakpoints
node.js doc: https://code.visualstudio.com/docs/nodejs/nodejs-debugging#_breakpoint-hit-counts

[joaomoreno]

That's too bad. I wonder if we should let the backend specify the message then?

[weinand]

Sure, I think we have already a feature request for this.

[isidorn]

/findDuplicates

[vscodebot]

Potential duplicates:

• Hit count input box could provide hint about expression syntax (#14421)
• Breakpoint hit count (#41713)
• Ugly input box for function breakpoints (#44557)
• Can't turn existing breakpoint into conditional breakpoint (#43463)
• Debug: help the user what to put into breakpoint hit count expression (#14363)

[isidorn]

Good job @vscodebot
fyi @chrmarti

Duplicate of #14363

[joaomoreno]

@chrmarti In Reddit there's a feature in which people can say "good bot" and the bot takes that as a good job. Could we feed that into the learning? Or just thumbs up?

[chrmarti]

Thumbs up might be the easiest and most intuitive way to do this. At the moment I don't have a way to feed that back to the duplicate detection because the main algorithm just compares vectorized representations of issues. Maybe we can still find a way to leverage that feedback (like simple evaluation).