Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkJS enablement: review the @ts-ignore comments #43973

Closed
egamma opened this issue Feb 19, 2018 · 1 comment
Closed

checkJS enablement: review the @ts-ignore comments #43973

egamma opened this issue Feb 19, 2018 · 1 comment
Assignees
@joaomoreno
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. verified Verification succeeded
Milestone
February 2018

Comments

@egamma
Copy link
Member

egamma commented Feb 19, 2018

We have enabled type checking for JS in the build folder. Some warnings were disabled with an @ts-ignore comment. Please review these warnings and check whether these are indeed type errors or whether the typings need to be fixed.

To search for the warnings search for

// @ts-ignore review

Based on git blame the code with these warnings was last touched by @joaomoreno and @dbaeumer
@egamma egamma added this to the February 2018 milestone Feb 19, 2018
@egamma egamma mentioned this issue Feb 19, 2018
Closed
@kieferrm kieferrm mentioned this issue Feb 19, 2018
Closed
45 tasks
@joaomoreno joaomoreno added debt Code quality issues engineering VS Code - Build / issue tracking / etc. labels Feb 27, 2018
@dbaeumer
Copy link
Member

@joaomoreno thanks!

@egamma egamma added the verified Verification succeeded label Mar 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@joaomoreno @egamma @dbaeumer