Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear that dynamic workspace recommendations (based on repository URL) work via hashes #43201

Closed
letmaik opened this issue Feb 8, 2018 · 5 comments
Assignees
Labels
debt Code quality issues extensions Issues concerning extensions
Milestone

Comments

@letmaik
Copy link
Member

letmaik commented Feb 8, 2018

With 1.20.0 you now get extension recommendations based on the git remote URL of your repository.
When I first saw this, I immediately asked myself: "What? How? Are they sending repository URLs to some VS Code server?". Crawling the code I understood that the URL is hashed, so there is no privacy problem. I couldn't find a setting where I could disable the behaviour of VS Code sending such information, which added to my initial fear! :)

How can this be improved?

@vscodebot vscodebot bot added the git GIT issues label Feb 8, 2018
@joaomoreno joaomoreno assigned ramya-rao-a and unassigned joaomoreno Feb 8, 2018
@joaomoreno joaomoreno removed the git GIT issues label Feb 8, 2018
@ramya-rao-a ramya-rao-a added the extensions Issues concerning extensions label Feb 8, 2018
@ramya-rao-a
Copy link
Contributor

@letmaik Thanks for the feedback!

We hash the git remote urls using sha1 algorithm in the crypto module. These hashed urls and extension usage is logged in our telemetry which is then used to create a lookup table that feeds the extension recommendations system

We already have a setting telemetry.enableTelemetry that controls what information is sent from the product. See How to disable telemetry reporting.

If there is more feedback like yours, we may add a page to our blogs to address how we do recommendations in general.

@ramya-rao-a ramya-rao-a added this to the Backlog milestone Feb 9, 2018
@ramya-rao-a ramya-rao-a added the debt Code quality issues label Feb 9, 2018
@MrToph
Copy link

MrToph commented Feb 13, 2018

Yes, there is more feedback like his. I was also curious if and what you're tracking. Good to know that you can turn it off.

@kieferrm
Copy link
Member

See also #43471.

@freedom-police
Copy link

Even with hashing, the recommendation system is capable of connecting developers working on a repository with the extensions installed. This increased sharing of information is not clearly communicated.
Therefore, any information collected before pro-active recommendation fetching could be disabled should be deleted from the lookup table.

@ramya-rao-a ramya-rao-a modified the milestones: Backlog, September 2018 Sep 14, 2018
@ramya-rao-a ramya-rao-a assigned kieferrm and unassigned ramya-rao-a Sep 21, 2018
@bpasero bpasero modified the milestones: September 2018, October 2018 Sep 28, 2018
@kieferrm
Copy link
Member

Our FAQ describe our approach to telemetry and explain to users how to manage any kind of access to online services. They also describe the recommendation system. On first use, users are guided to our FAQ through a notification. There is no data that we could delete resulting from this scenario. We only keep the computed associations between remote hashes and extensions.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues extensions Issues concerning extensions
Projects
None yet
Development

No branches or pull requests

7 participants