Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Screen reader support in the terminal #42278

Closed
2 tasks done
Tyriar opened this issue Jan 28, 2018 · 3 comments
Closed
2 tasks done

Test: Screen reader support in the terminal #42278

Tyriar opened this issue Jan 28, 2018 · 3 comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 28, 2018

Tests #8339

Complexity: 4


The terminal now support screen readers, targeting NVDA on Windows and VoiceOver on macOS. Here is an overview of what's supported:

  • Terminal is announced when focused
  • Characters entered into the terminal via keyboard are announced
    • Character and word echo settings are respected
  • Read command output upon execution (up to 20 rows to prevent DOM from growing)
  • Support screen reader navigation within current viewport
    • NVDA can read out row content on mouse over
    • NVDA/VoiceOver navigation mode works with rows (esc to enter this mode in NVDA, press left to navigate to rows in VoiceOver)

Please learn the basics of the screen reader and attempt to use the terminal. Note that you will need to switch the editor to "Screen Reader Optimized" mode (alt+f1).

Known issues

  • Characters are not read out when deleted from the prompt
  • Reading out history when navigating shells using up/down sometimes doesn't work
  • Holding down up/down while navigating rows in NVDA can skip over the terminal
@bpasero
Copy link
Member

bpasero commented Jan 29, 2018

@Tyriar not for January?

@Tyriar Tyriar added this to the January 2018 milestone Jan 29, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Jan 29, 2018

@bpasero fixed, thanks for spotting it.

@sandy081
Copy link
Member

@Tyriar #42415 is blocking to test this.

@mjbvz mjbvz removed their assignment Jan 30, 2018
@sandy081 sandy081 assigned joaomoreno and unassigned sandy081 Jan 31, 2018
@joaomoreno joaomoreno removed their assignment Jan 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants