Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect rendering of key bindings with Spanish keyboard on linux #4084

Closed
mtrivolli opened this issue Mar 13, 2016 · 1 comment
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux verified Verification succeeded
Milestone

Comments

@mtrivolli
Copy link

According to the documentation, vscode renders the key bindings using the system keyboard layout.
But in my case, the rendered key bindings do not seem to correspond to my layout.

For instance, the split command is shown to be ctrl + ç, however that combination toggles a line comment.

The toggle line comment is shown to be ctrl + -, but such combination reduces the font size.

The output of localectl status is:

   System Locale: LANG=es_ES.UTF-8
       VC Keymap: n/a
      X11 Layout: es
       X11 Model: pc102
     X11 Options: compose:ralt,terminate:ctrl_alt_bksp
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues linux Issues with VS Code on Linux labels Aug 31, 2016
@alexdima alexdima added this to the Backlog milestone Aug 31, 2016
@alexdima alexdima added the keyboard-layout Keyboard layout issues label Mar 1, 2017
@alexdima
Copy link
Member

I have validated that we now (i.e. after PR #22894 aka #17521 -- in tomorrow's Insiders build) appear to behave correctly for this keyboard layout

image


Analysis of default keybinding for editor.action.commentLine

  • editor.action.commentLine is bound by default to the key code binding ctrl+/
  • / can be produced through one scan code combination: Shift+[Digit7]. i.e.:
    image
  • The key code binding ctrl+/ is therefore mapped to the scan code binding Ctrl+Shift+[Digit7] and the F1 command picker now correctly reflects that:
    image
    image
  • That is unfortunate, but correct. We don't ship with keyboard layout specific default keybindings, that is something you can upvote in Support contributing different keybindings based on keyboard layout #1240

Analysis of default keybinding for workbench.action.splitEditor

  • workbench.action.splitEditor is bound by default to the key code binding ctrl+\
  • \ can be produced through three scan code combinations: Ctrl+Alt+[Minus], Ctrl+Alt+[Backquote] and Ctrl+Alt+Shift+[Backquote]. i.e.:
    image
  • because Ctrl must be used to produce the visual character, the key code binding ctrl+\ is not mappable . i.e. the scan code combo would need to be something like Ctrl+ Ctrl+Alt+[Minus], which we don't support.
  • therefore, the action is unbound by default. That is unfortunate, but correct.

This makes me believe the fix in PR #22894 aka #17521 resolves this issue. Please double check in tomorrow's insiders build.

@alexdima alexdima modified the milestones: March 2017, Backlog Mar 23, 2017
@roblourens roblourens added the verified Verification succeeded label Mar 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants