Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickOpen: Allow any order for search terms #38877

Closed
TroX-oO opened this issue Nov 21, 2017 · 1 comment
Closed

QuickOpen: Allow any order for search terms #38877

TroX-oO opened this issue Nov 21, 2017 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues

Comments

@TroX-oO
Copy link

TroX-oO commented Nov 21, 2017

It could save a lot of time if the search terms in quickopen was not taken in order. I explain:

My project is like so:
tree

If I search for index everything is fine, I get the expected 2 index.js files:
result_index

If I search for bar index, also I get the right index.js file:
result_ok

But often during my development i'm searching first by file name, and then I remember that there is not only one file named like this in my project, so I want to specify the "module" afterwards like this:

result_ko

I think it would be a great idea to show the same results for index bar as the ones for bar index but only if there is no better matches.

Some example to illustrate with the following tree:

project/
├── indexable/
│   ├── index.js
│   └── bar.js
└── bar/
     ├── index.js
     └── bar.js

Search terms: index bar
Results:
1st/ indexable/bar.js (because the order of terms matches the file path)
2nd/ bar/index.js (as there is two matching terms, but in wrong order)

Search terms: indexbar
Results:
1st/ indexable/bar.js
bar/index.js is not a match cause it does not match any of the terms

@vscodebot vscodebot bot added the search Search widget and operation issues label Nov 21, 2017
@TroX-oO
Copy link
Author

TroX-oO commented Nov 21, 2017

Just see that it duplicates #30404
You can close it. I will up vote the other issue ;)

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 21, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

2 participants