Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch configs: resolve replacement patterns in object keys, in addition to values #38455

Closed
roblourens opened this issue Nov 15, 2017 · 1 comment
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality

Comments

@roblourens
Copy link
Member

From https://github.com/Microsoft/vscode-chrome-debug/issues/226

A chrome-debug config can have

            "sourceMapPathOverrides": {
                "webpack:///C:/Depot/Impakt/DNA/DNACore/*": "${webRoot}/*" // SUCCEEDS
                //"webpack:///${workspaceRoot}/*": "${webRoot}/*" // FAILS
                //"webpack:///${webRoot}/*": "${webRoot}/*"  // FAILS
            },   

vscode replaces ${workspaceRoot} in values, and the adapter replaces ${webRoot} in values, and now after microsoft/vscode-chrome-debug#543, in keys as well. It would be great if vscode would replace ${workspaceRoot} in keys.

One issue is that you can have collisions where two keys are the same after applying these replacements. In chrome-debug now, the last one wins where "last" is technically undefined.

@roblourens roblourens added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Nov 15, 2017
@weinand
Copy link
Contributor

weinand commented Nov 15, 2017

duplicate of #34059.
I've just raised the priority of this to "On Deck".

@weinand weinand closed this as completed Nov 15, 2017
@weinand weinand added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 15, 2017
@weinand weinand removed their assignment Nov 15, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants