Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode walks all files under project, even excluded directories #3703

Closed
ridiculousfish opened this issue Mar 4, 2016 · 2 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality verified Verification succeeded
Milestone

Comments

@ridiculousfish
Copy link

VS Code currently walks all everything under the project's directory, even excluded files.

  1. Go to some project folder

  2. Create a big directory hierarchy in a subfolder. git clone https://github.com/torvalds/linux.git will do it.

  3. Launch VSCode and open the project folder

  4. Using fs_usage or equivalent tool, notice that VS Code is walking that hierarchy and stat'ing all files in it

  5. Try to add a setting to exclude the file:

        "files.exclude": {
            "linux/": true
        }
    
  6. Repeat step 3 and 4. Notice that the linux directory no longer appears in the sidebar, but VS Code still walks the directory and stats everything.

In my case I have a few million files, and this directory traversal is a serious slowdown.

VS Code Version 0.10.9 (0.10.9) 45d6935, OS X 10.11.3

@bpasero
Copy link
Member

bpasero commented Mar 4, 2016

We currently do not support to exclude folders from our watching infrastructure so files.exclude does not have an impact. One reason is that e.g. we want to hide the .git folder from the explorer but we cannot disable file events for that folder because git relies on these events.

We might need to add a new option to configure watcher exclusions.

@isidorn isidorn added feature-request Request for new features or functionality workbench labels Mar 4, 2016
@bpasero
Copy link
Member

bpasero commented Mar 14, 2016

For March we support a new setting files.watcherExclude that can be defined to control this behaviour.

@bpasero bpasero closed this as completed Mar 14, 2016
@bpasero bpasero added this to the March 2016 milestone Mar 14, 2016
@bpasero bpasero self-assigned this Mar 14, 2016
@bpasero bpasero added the verified Verification succeeded label Apr 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants