Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy search results are not prioritized well. #36166

Closed
thekashifmalik opened this issue Oct 12, 2017 · 6 comments
Closed

Fuzzy search results are not prioritized well. #36166

thekashifmalik opened this issue Oct 12, 2017 · 6 comments
Assignees
Labels
quick-pick Quick-pick widget issues search Search widget and operation issues

Comments

@thekashifmalik
Copy link

  • VSCode Version: Code 1.17.1 (1e9d365, 2017-10-10T14:10:17.189Z)
  • OS Version: Darwin x64 16.7.0
  • Extensions:
Extension Author (truncated) Version
postgresql JPT 0.0.2
swift Kas 0.0.3
vscode-docker Pet 0.0.18
project-manager ale 0.21.1
vscode-puppet bit 0.4.5
better-toml bun 0.3.1
path-intellisense chr 1.4.2
vscode-eslint dba 1.3.2
vscode-yaml-validation dja 0.0.1
python don 0.7.0
gitlens eam 5.6.3
tslint eg2 1.0.11
vimL fal 0.0.3
auto-close-tag for 0.5.1
hive-sql jos 0.0.2
vscode-rust kal 0.4.2
restructuredtext lex 38.0.0
Go luk 0.6.66
MagicPython mag 1.0.12
mssql ms- 1.2.0
debugger-for-chrome msj 3.3.1
java red 0.11.0
vscode-icons rob 7.15.0
vscode-nginx sha 0.4.1
slack soz 0.0.13
expand-selection-to-scope vit 0.2.0
vim vsc 0.10.1
jinja who 0.0.8
change-case wma 1.0.0

(1 theme extensions excluded)


I use fuzzy search a lot and after switching to vscode I'm noticing that it's rare for the target file to appear in the top 3 results. It's almost always 10 or 15 results down. Sublime fuzzy search works well as does my setup in vim (using FZF).

Is there a point in having vscode re-invent the wheel and maintain it's own algorithm? Would it be possible to re-use other open source libraries such as FZF?

OSS FTW

Reproduces without extensions: Yes

@vscodebot vscodebot bot added the search Search widget and operation issues label Oct 12, 2017
@roblourens
Copy link
Member

Can you provide some examples that don't work well?

@thekashifmalik
Copy link
Author

thekashifmalik commented Oct 13, 2017

Sure. In the Django codebase when looking for the file django/core/signals.py I type djan co sig.

On vscode the results are far down:

screenshot 2017-10-12 17 01 12

On vim (using FZF) it's the first hit:

screenshot 2017-10-12 17 01 52

In sublime it is also the first result.

@roblourens roblourens assigned bpasero and unassigned roblourens Oct 13, 2017
@bpasero
Copy link
Member

bpasero commented Oct 13, 2017

@thekashifmalik did a little bit of tweaks here for our 1.18 insider build, can you grab it and see if your examples work any better? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

@bpasero bpasero added the quick-pick Quick-pick widget issues label Oct 13, 2017
@bpasero
Copy link
Member

bpasero commented Oct 13, 2017

I see the challenge for the scorer here is that there are good camelcase matches on the path portion:

image

They will cause a much higher boost compared to the relatively short matches here:

image

@bpasero
Copy link
Member

bpasero commented Oct 20, 2017

Fixed via 9d40f0c

@bpasero bpasero closed this as completed Oct 20, 2017
@thekashifmalik
Copy link
Author

Nice, this is working much better on insiders!

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
quick-pick Quick-pick widget issues search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

4 participants